Skip to content

Ask the driver for a fault only after a loss the validation layer records - #106

Merged
tomaszbk merged 2 commits into
mainfrom
rhi/fault-info-after-a-queue-loss
Nov 16, 2026
Merged

tomaszbk merged 2 commits into
mainfrom
rhi/fault-info-after-a-queue-loss

Conversation

@5hif7y

@5hif7y 5hif7y commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes #100.

Changes

  • vk_check and vk_lost (rhi/vulkan_device.odin) take described (true by default).
  • vkCreateComputePipelines and vkCreateGraphicsPipelines (rhi/vulkan_resources.odin) pass described = false. A loss they report still fails the device with .Lost and names the pipeline and the pass where the GPU stopped, but does not ask vkGetDeviceFaultInfoEXT.
  • Why: the validation layer records a loss only from queue and wait calls. After a loss from pipeline creation it reports the fault-info call ("device has not been found to be in a lost state"), and that counts in validation_errors, so a run under validation gets an error that is not Mirai's.
  • What is given up: the driver's description for those losses. In the runs of A GPU reset that no call reports hangs frame_begin, and with it every later GPU test #85 it was "No fault detected".

Tests

🤖 Generated with Claude Code

…ords

When pipeline creation returns VK_ERROR_DEVICE_LOST, the validation
layer has not marked the device lost and reports
vkGetDeviceFaultInfoEXT as a validation error. Pipeline creation now
marks the loss without asking for its description.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ation layer

The query is valid after any VK_ERROR_DEVICE_LOST; only the validation layer
flags it when no submission or wait reported the loss. Without the layer the
driver's description of such a loss is kept. The workaround is listed under
Drivers in the dependency workarounds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomaszbk
tomaszbk merged commit 497d3cb into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The validation layer warns on vkGetDeviceFaultInfoEXT when only pipeline creation reported the device lost

2 participants