Repository navigation
Ask the driver for a fault only after a loss the validation layer records - #106
Merged
Merged
Conversation
…ords When pipeline creation returns VK_ERROR_DEVICE_LOST, the validation layer has not marked the device lost and reports vkGetDeviceFaultInfoEXT as a validation error. Pipeline creation now marks the loss without asking for its description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ation layer The query is valid after any VK_ERROR_DEVICE_LOST; only the validation layer flags it when no submission or wait reported the loss. Without the layer the driver's description of such a loss is kept. The workaround is listed under Drivers in the dependency workarounds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100.
Changes
vk_checkandvk_lost(rhi/vulkan_device.odin) takedescribed(true by default).vkCreateComputePipelinesandvkCreateGraphicsPipelines(rhi/vulkan_resources.odin) passdescribed = false. A loss they report still fails the device with.Lostand names the pipeline and the pass where the GPU stopped, but does not askvkGetDeviceFaultInfoEXT.validation_errors, so a run under validation gets an error that is not Mirai's.frame_begin, and with it every later GPU test #85 it was "No fault detected".Tests
mirai check rhi;mirai test rhi: 31/31.frame_begin, and with it every later GPU test #85 and ADdgi_Tracedispatch runs 30 times its length in the full render suite and resets the GPU #86, and the simulated loss (device_lose) skips fault info already, so no test can reach this path without a real reset.🤖 Generated with Claude Code