Repository navigation
fix(temporal)!: qualify shared calendar grids, feature windows and labels - #98
Merged
Merged
Conversation
…-timestampless-row-mode
…-timestampless-row-mode
…estampless-row-mode
…-timestampless-row-mode
…-timestampless-row-mode
…-timestampless-row-mode
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76. Closes #94.
This is the maintainer-directed temporal-contract consumer batch. It normally integrates the existing published-Specs component PR102, daily-grid component PR104 and labeling component PR95 with row-only and finite temporal feature windows. Reviewed head: c69845d, based on prior main3507071; merged asb0d2027.
Merged as b0d2027 on2026-10-18T02:23:53Z after all40applicable checks passed and one configured315skip. Exact reviewedc698/tested syntheticd7c6/actual mergedb0dtrees match6ecdca0. Issues76/94closed. Components95/102/104closed as consolidated after verifying their original ancestry and preserving recoverable history. Landed branches retired safely. Source-only maintainer-batching policy98fe25b is included, not a separate policy-only PR. No release or deployment.
Latest correction: shared session-label identifiers no longer fabricate physical elapsed duration. Actual installed6cf produces4days from July3/7 identifiers; a declared naive New York clock also targets the wrong exit across spring DST (01:00 +2physical hours exited03:00 instead of04:00). The exact installed base fails29cases with72positive controls. The repair reuses the existing numerical kernel on UTC instants and restores input clock representation. Shared identifiers leave duration unset; standalone legacy Date differences remain unchanged.
Current qualification
The latest incremental merge includes PR95's timestamp-free legacy export repair at 2259bae. Its actual public installed-package workflow fails to save an Object-valued unknown duration before the fix; twelve new source cases fail before repair and 427 labeling cases pass afterward. The combined head passes 135 focused cases and the full qualification below.
Scope and behavior
Dependencies and compatibility
The three component heads are normal ancestors of the reviewed batch, preserving their source and regression history. They are closed as consolidated after the verified batch merge, not merged separately. Runtime metadata honestly requires published ml4t-specs>=0.2.0,<0.3.0. Independent CI101 is merged; final Python3.15support remains separately owned by PR93, refreshed only after this batch landed. This is next-minor0.2development, not the historical0.1.7patch or a release request.
Completed runtime and artifact qualification at 85764b5
Regression evidence
Actual public price-to-return-to-feature workflows fail before implementation. Real producer mutations that count rows/observed dates as sessions, strip timezones, misinterpret declared naive timestamps, or allow lazy predicate pushdown each fail the numerical consumers they should prevent. Correct producers were restored before clean checks and commits. Independent annualization regressions are now maintained in public CI.
All applicable current-head hosted checks completed before the ordinary exact-head merge. Final Python3.15support remains separately gated in93. No all-feature temporal support, release or deployment is claimed.
AI assistance: Codex reviewed the existing source and discussion, reproduced the public workflows, implemented and reviewed source/tests/docs, and executed the listed checks. No independent human review is claimed.