feat: support negation globs in config.yaml#3156
Open
btrautmann wants to merge 6 commits intomobile-dev-inc:mainfrom
Open
feat: support negation globs in config.yaml#3156btrautmann wants to merge 6 commits intomobile-dev-inc:mainfrom
btrautmann wants to merge 6 commits intomobile-dev-inc:mainfrom
Conversation
proksh
reviewed
Apr 9, 2026
Upstream added 018_additional_config_files in mobile-dev-inc#3150, conflicting with our 018_negation_with_specific_positive fixture. Renumbered ours to 019. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Extract duplicated matcher-building logic into a local buildMatchers function - Fix error message to only list positive globs under "inclusion pattern(s) did not match", excluding !-prefixed negation patterns which are not inclusions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
proksh
approved these changes
Apr 9, 2026
Contributor
proksh
left a comment
proksh
left a comment
There was a problem hiding this comment.
Nice.
It will be good if you can test "all negation, no positive" case for flow selection as well.
Contributor
|
What's the expected outcome? Zero flows? |
Contributor
I was thinking just excluding the mentioned exclusions and running all remaining flows. But you have more context of how things should work, and if Zero flows make more sense, lets go with it. |
Author
|
@Fishbowler @proksh lmk if you'd like me to make any further changes, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds support for negation globs in
config.yamlto support excluding specific globs before Maestro processes them as flows. This is helpful when you have other.yaml(similar toconfig.yaml) files in our workspace but don't want them to be treated as flows, as it avoids needing to either restructure your project (add a nested directory for your workspace) or writing custom code to generate aconfig.yamlwithout the excluded file at test time.copilot:summary
Testing
Added fixtures and tests to exercise the new logic.