refactor(ui): share desktop chrome with history - #983
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Sep 5, 2026
benvinegar
marked this pull request as ready for review
September 5, 2026 22:41
Contributor
|
Too many files changed for review (54 files, 50 file limit). Bypass the limit by tagging |
benvinegar
force-pushed
the
feat/hunk-log-chrome
branch
from
September 5, 2026 22:54
db05b3e to
54ed606
Compare
benvinegar
force-pushed
the
feat/hunk-log-chrome
branch
from
September 6, 2026 01:00
9396f68 to
aaf4f64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Problem
The first history implementation used a focused raw terminal loop, so interactive history did not share Hunk's desktop-style menu bar, dialogs, theme picker, command authority, or visual language. That made the transition between history and review feel like two separate products.
Approach
LogApphunk logunchanged and shell-nativeInteraction
F10opens the menu barqreturns from review to the retained log state, then quits historyValidation
bun run typecheckbun run lintbun run deps:checkbun run testbun run test:integrationbun run test:tty-smokeTested on Linux with Git, Jujutsu, tmux, and a real TTY. Windows was not tested directly.
Visual evidence
Manual real-terminal validation was performed. Media can be added while this PR remains draft.
Non-goals
AppHostinto a permanent multimode IDE hosthunk logThis PR description was generated by Pi using GPT-5.6-sol