REL-2749: Removed prepare_command to allow cocoapods publish#95
REL-2749: Removed prepare_command to allow cocoapods publish#95msoumya-engg-sdk merged 1 commit intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the prepare_command from the CocoaPods podspec to enable CocoaPods publishing, while also reverting the plugin version from 6.8.0 back to 6.7.0 and the MoEngage iOS SDK dependency from 10.10.0 to 10.08.0. The prepare_command was previously auto-generating the version constant file during pod installation, which may have been causing issues with the CocoaPods publishing process.
Changes:
- Removed
prepare_commandscript from MoEngagePluginBase.podspec that auto-generated version constants - Reverted plugin version from 6.8.0 to 6.7.0 across all configuration files
- Reverted MoEngage iOS SDK dependency from 10.10.0 to 10.08.0
- Updated CHANGELOG to use placeholder text instead of specific version/date information
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MoEngagePluginBase.podspec | Removed prepare_command that auto-generated version file during pod installation |
| package.json | Reverted plugin version to 6.7.0 and SDK dependency to 10.08.0 |
| Sources/MoEngagePluginBase/MoEngagePluginConstants+Version.swift | Updated version constant to 6.7.0 |
| Package.swift | Reverted MoEngage SDK dependency to exact version 10.08.0 |
| CHANGELOG.md | Replaced specific version (6.8.0) and date with placeholder text |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Release Date | ||
|
|
||
| ## 6.8.0 | ||
| ## Release Version |
There was a problem hiding this comment.
The CHANGELOG now uses placeholder text ("Release Date" and "Release Version") instead of actual release information. This makes the changelog incomplete and unhelpful for users trying to understand what changed in which version. Consider either:
- Using the actual release date and version (02-02-2026 and 6.8.0) if this represents a new release
- Removing this entry entirely if the release hasn't been finalized yet
- Following the established pattern in the rest of the changelog where each entry has a specific date and version number
| "sdkVerMin": "10.08.0", | ||
| "packages": [ | ||
| { | ||
| "name": "MoEngagePluginBase", | ||
| "version": "6.8.0", | ||
| "version": "6.7.0", |
There was a problem hiding this comment.
This PR appears to be reverting from version 6.8.0 back to 6.7.0, but the PR title and description don't clearly explain why a version downgrade is necessary to "allow cocoapods publish". The title suggests this is about removing prepare_command, but doesn't mention that this also reverts to an older version. Consider clarifying in the PR description:
- Why the version needs to be reverted
- Whether version 6.8.0 will be re-released after this change
- The relationship between the prepare_command removal and the version downgrade
Jira Ticket
Description