Skip to content

REL-2749: Removed prepare_command to allow cocoapods publish #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msoumya-engg-sdk merged 1 commit into from
Feb 2, 2026
Merged

REL-2749: Removed prepare_command to allow cocoapods publish #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
# 02-02-2026
# Release Date

## 6.8.0
## Release Version
Comment on lines +1 to +3
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG now uses placeholder text ("Release Date" and "Release Version") instead of actual release information. This makes the changelog incomplete and unhelpful for users trying to understand what changed in which version. Consider either:

  1. Using the actual release date and version (02-02-2026 and 6.8.0) if this represents a new release
  2. Removing this entry entirely if the release hasn't been finalized yet
  3. Following the established pattern in the rest of the changelog where each entry has a specific date and version number

Copilot uses AI. Check for mistakes.

- Updated MoEngage-iOS-SDK to 10.10.0
- Added no-code SDK file based initialization
- Updated CD token usage
- [minor] Added no-code SDK file based initialization
- [NA] Updated CD token usage

# 18-11-2025

Expand Down
7 changes: 0 additions & 7 deletions MoEngagePluginBase.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,6 @@ Pod::Spec.new do |s|
s.dependency 'MoEngage-iOS-SDK', config.sdkVerMin
s.dependency 'MoEngage-iOS-SDK/InApps'

version_file = "Sources/#{s.name}/MoEngagePluginConstants+Version.swift"
s.prepare_command = <<-CMD
echo "// Generated file, do not edit\n" > #{version_file}
echo "import Foundation\n" >> #{version_file}
echo "extension MoEngagePluginConstants {\n static let version = \\"#{s.version}\\"\n}" >> #{version_file}
CMD

test_file_glob = "Tests/#{s.name}Tests/**/*.{swift}"
s.test_spec 'Tests' do |ts|
ts.ios.deployment_target = '13.0'
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ let package = Package(
],
dependencies: [
// Dependencies declare other packages that this package depends on.
.package(url: "https://github.com/moengage/apple-sdk.git", exact: "10.10.0")
.package(url: "https://github.com/moengage/apple-sdk.git", exact: "10.08.0")
],
targets: [
// Targets are the basic building blocks of a package. A target can define a module or a test suite.
Expand Down
2 changes: 1 addition & 1 deletion Sources/MoEngagePluginBase/MoEngagePluginConstants+Version.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
import Foundation

extension MoEngagePluginConstants {
static let version = "6.8.0"
static let version = "6.7.0"
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "MoEngagePluginBase",
"postBuild": "Utilities/post_build.rb",
"sdkVerMin": "10.10.0",
"sdkVerMin": "10.08.0",
"packages": [
{
"name": "MoEngagePluginBase",
"version": "6.8.0",
"version": "6.7.0",
Comment on lines +4 to +8
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to be reverting from version 6.8.0 back to 6.7.0, but the PR title and description don't clearly explain why a version downgrade is necessary to "allow cocoapods publish". The title suggests this is about removing prepare_command, but doesn't mention that this also reverts to an older version. Consider clarifying in the PR description:

  1. Why the version needs to be reverted
  2. Whether version 6.8.0 will be re-released after this change
  3. The relationship between the prepare_command removal and the version downgrade

Copilot uses AI. Check for mistakes.
"changelog": "CHANGELOG.md",
"tagPrefix": "pluginBase-"
}
Expand Down
Loading