Collector Fixes#34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to collectors
RAPL collector rework:
The RAPL collector now uses the /sys/class/powercap interface to collect power usage data. Previously it used the /dev/cpu/msr interface which was vendor-specific and didn't work on some systems. The current implementation aims to fix that issue.
NVML collector update:
The NVML collector now discovers all present GPUs available on the system. It also collects metrics for each of them.
Other fixes:
Added a duration_cast to all of the timestamps generated by collectors to enforce unit correctness.