smite: add commitment_signed message codec implementation by kartikangiras · Pull Request #24 · morehouse/smite

kartikangiras · 2026-04-03T18:08:37Z

Add support for commitment-signed codec for BOLT 2 message.

kartikangiras · 2026-04-04T06:12:56Z

Hi @morehouse , Could you PTAL into this PR, it is the part of milestone 2 adding support for commitment-signed codec (channel-ready is implemented in other PR by another contributor). Thanks.

morehouse

Thanks for working on this. Please make sure CI passes before requesting another review. You should be able to run all the CI commands locally (e.g., cargo test, cargo fmt, cargo clippy --all-targets --all-features -- -D warnings)

morehouse

Please squash into one commit.

kartikangiras · 2026-04-09T19:36:01Z

@morehouse I have made all the necessary changes and ran all the checks locally.

morehouse · 2026-04-10T18:27:55Z

CI still doesn't pass...

kartikangiras · 2026-04-13T12:36:08Z

@morehouse The command (cargo clippy --all-targets --all-features -- -D warnings) fails locally on ARM64 based systems such as MacOS. due to which I am not able to cross verify locally my code. I have been facing this issue on all of my PR checks.

ekzyis · 2026-04-13T13:30:29Z

@morehouse The command (cargo clippy --all-targets --all-features -- -D warnings) fails locally on ARM64 based systems such as MacOS. due to which I am not able to cross verify locally my code. I have been facing this issue on all of my PR checks.

Oh, interesting! I think this is worth an issue, so we can fix it. Can you create one? Can you also share the logs in the issue then?

kartikangiras · 2026-04-13T14:07:05Z

@morehouse The command (cargo clippy --all-targets --all-features -- -D warnings) fails locally on ARM64 based systems such as MacOS. due to which I am not able to cross verify locally my code. I have been facing this issue on all of my PR checks.

Oh, interesting! I think this is worth an issue, so we can fix it. Can you create one? Can you also share the logs in the issue then?

@ekzyis I have created an issue for this. While investigating further, I have founded the root cause of this problem and the necessary fix for it.

kartikangiras · 2026-04-30T18:51:14Z

@morehouse I have locally tested each command on a linux based machine (it took time because i was on a macbook and it natively does not support these commands).

kartikangiras · 2026-05-01T18:20:37Z

@morehouse I have made all the necessary require changes as reviewed by you.

morehouse · 2026-05-04T15:41:50Z

+        let mut stream = TlvStream::new();
+
+        if let Some(txid) = self.funding_txid {
+            stream.add(1, txid.to_byte_array().to_vec());


We should create and use a TLV_FUNDING_TXID constant like we do for other codecs.

morehouse · 2026-05-04T15:43:43Z

+            Some(Txid::from_byte_array(
+                bytes.try_into().expect("length checked above"),


We should be using the WireFormat methods for Txid in encode and decode.

morehouse · 2026-05-04T15:46:48Z

+            htlc_signatures.push(sig);
+        }
+
+        let tlvs = CommitmentSignedTlvs::decode(cursor)?;


I'd prefer to have consistency between the codecs -- either use the from_stream pattern here, or update all other codecs to move that logic into TLV decode functions.

morehouse · 2026-05-04T15:49:23Z

+    /// Returns `Truncated` if the payload is too short for any fixed field, also can return
+    /// `InvalidSignature` and TLV errors.


Suggested change

/// Returns `Truncated` if the payload is too short for any fixed field, also can return

/// `InvalidSignature` and TLV errors.

/// Returns `Truncated` if the payload is too short, `InvalidSignature` if any signature

/// is malformed, or a TLV error if the TLV stream is malformed.

morehouse · 2026-05-04T16:04:47Z

+    }
+
+    #[test]
+    fn funding_txid_roundtrip() {


Suggested change

fn funding_txid_roundtrip() {

fn roundtrip_with_funding_txid() {

morehouse · 2026-05-04T16:52:00Z

+    }
+
+    #[test]
+    fn different_funding_txids() {


Suggested change

fn different_funding_txids() {

fn encode_different_funding_txids() {

morehouse · 2026-05-04T16:53:16Z

+    fn encode_no_htlcs() {
+        let msg = sample_commitment_signed_no_htlcs();
+        let encoded = msg.encode();
+        assert!(encoded.len() > 96);


Why did you get rid of the exact length check here?

morehouse · 2026-05-04T16:53:19Z

+    fn encode_with_htlcs() {
+        let msg = sample_commitment_signed_with_htlcs();
+        let encoded = msg.encode();
+        assert!(encoded.len() > 32 + 64 + 2 + 2 * 64);


Why did you get rid of the exact length check here?

morehouse · 2026-05-04T17:01:03Z

+        let sk3 = SecretKey::from_byte_array([0x33; 32]).expect("valid secret");
+        let msg3 = Message::from_digest([0xcc; 32]);
+        let sig3 = secp.sign_ecdsa(msg3, &sk3);


Looks like a helper function for creating signatures could save several lines of code.

morehouse · 2026-05-04T17:01:59Z

+    }
+
+    #[test]
+    fn funding_txid_with_htlcs_roundtrip() {


Suggested change

fn funding_txid_with_htlcs_roundtrip() {

fn roundtrip_funding_txid_with_htlcs() {

morehouse requested changes Apr 6, 2026

View reviewed changes

Comment thread smite/src/bolt.rs Outdated

Comment thread smite/src/bolt.rs Outdated

Comment thread smite/src/bolt/commitment_signed.rs

Comment thread smite/src/bolt/commitment_signed.rs Outdated

Comment thread smite/src/bolt/commitment_signed.rs Outdated

kartikangiras force-pushed the codec-commitment-signed branch from c0dfbac to 35607c7 Compare April 6, 2026 18:09

morehouse requested changes Apr 7, 2026

View reviewed changes

kartikangiras force-pushed the codec-commitment-signed branch from 326f594 to 88aab2a Compare April 7, 2026 18:42

kartikangiras requested a review from morehouse April 8, 2026 19:16

kartikangiras force-pushed the codec-commitment-signed branch from 88aab2a to b9d0980 Compare April 9, 2026 19:35

kartikangiras force-pushed the codec-commitment-signed branch from b9d0980 to 8a5a344 Compare April 11, 2026 07:27

kartikangiras force-pushed the codec-commitment-signed branch from 8a5a344 to 6f941d0 Compare April 30, 2026 18:49

kartikangiras force-pushed the codec-commitment-signed branch from 6f941d0 to e01403c Compare April 30, 2026 19:20

morehouse requested changes Apr 30, 2026

View reviewed changes

kartikangiras force-pushed the codec-commitment-signed branch from e01403c to a600125 Compare May 1, 2026 17:50

kartikangiras requested a review from morehouse May 1, 2026 17:58

smite: implement commitment_signed message codec

215b12f

kartikangiras force-pushed the codec-commitment-signed branch from a600125 to 215b12f Compare May 1, 2026 18:20

morehouse requested changes May 4, 2026

View reviewed changes

		Some(Txid::from_byte_array(
		bytes.try_into().expect("length checked above"),

		/// Returns `Truncated` if the payload is too short for any fixed field, also can return
		/// `InvalidSignature` and TLV errors.

	fn funding_txid_roundtrip() {
	fn roundtrip_with_funding_txid() {

	fn different_funding_txids() {
	fn encode_different_funding_txids() {

	fn funding_txid_with_htlcs_roundtrip() {
	fn roundtrip_funding_txid_with_htlcs() {

Conversation

kartikangiras commented Apr 3, 2026

Uh oh!

kartikangiras commented Apr 4, 2026

Uh oh!

morehouse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

morehouse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kartikangiras commented Apr 9, 2026

Uh oh!

morehouse commented Apr 10, 2026

Uh oh!

kartikangiras commented Apr 13, 2026

Uh oh!

ekzyis commented Apr 13, 2026

Uh oh!

kartikangiras commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kartikangiras commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kartikangiras commented May 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kartikangiras commented Apr 13, 2026 •

edited

Loading