Skip to content

smite: add commitment_signed message codec implementation #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartikangiras wants to merge 1 commit into
base: master
Choose a base branch
from
Open

smite: add commitment_signed message codec implementation #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions smite/src/bolt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ mod accept_channel;
mod accept_channel2;
mod attribution_data;
mod channel_ready;
mod commitment_signed;
mod error;
mod funding_created;
mod funding_signed;
Expand Down Expand Up @@ -35,6 +36,7 @@ pub use accept_channel::{AcceptChannel, AcceptChannelTlvs};
pub use accept_channel2::{AcceptChannel2, AcceptChannel2Tlvs};
pub use attribution_data::{AttributionData, TruncatedHmac};
pub use channel_ready::{ChannelReady, ChannelReadyTlvs};
pub use commitment_signed::{CommitmentSigned, CommitmentSignedTlvs};
pub use error::Error;
pub use funding_created::FundingCreated;
pub use funding_signed::FundingSigned;
Expand Down Expand Up @@ -143,6 +145,8 @@ pub mod msg_type {
pub const UPDATE_FULFILL_HTLC: u16 = 130;
/// `update_fail_htlc` message (BOLT 2).
pub const UPDATE_FAIL_HTLC: u16 = 131;
/// `commitment_signed` message (BOLT 2).
pub const COMMITMENT_SIGNED: u16 = 132;
/// `update_fail_malformed_htlc` message (BOLT 2).
pub const UPDATE_FAIL_MALFORMED_HTLC: u16 = 135;
/// Gossip timestamp filter message (BOLT 7).
Expand Down Expand Up @@ -195,6 +199,8 @@ pub enum Message {
UpdateFulfillHtlc(UpdateFulfillHtlc),
/// `update_fail_htlc` message (type 131).
UpdateFailHtlc(UpdateFailHtlc),
/// `commitment_signed` message (type 132).
CommitmentSigned(CommitmentSigned),
/// `update_fail_malformed_htlc` message (type 135).
UpdateFailMalformedHtlc(UpdateFailMalformedHtlc),
/// Gossip timestamp filter message (type 265).
Expand Down Expand Up @@ -237,6 +243,7 @@ impl Message {
Self::TxAbort(_) => msg_type::TX_ABORT,
Self::UpdateFulfillHtlc(_) => msg_type::UPDATE_FULFILL_HTLC,
Self::UpdateFailHtlc(_) => msg_type::UPDATE_FAIL_HTLC,
Self::CommitmentSigned(_) => msg_type::COMMITMENT_SIGNED,
Self::UpdateFailMalformedHtlc(_) => msg_type::UPDATE_FAIL_MALFORMED_HTLC,
Self::GossipTimestampFilter(_) => msg_type::GOSSIP_TIMESTAMP_FILTER,
Self::Unknown { msg_type, .. } => *msg_type,
Expand Down Expand Up @@ -270,6 +277,7 @@ impl Message {
Self::TxAbort(m) => out.extend(m.encode()),
Self::UpdateFulfillHtlc(m) => out.extend(m.encode()),
Self::UpdateFailHtlc(m) => out.extend(m.encode()),
Self::CommitmentSigned(m) => out.extend(m.encode()),
Self::UpdateFailMalformedHtlc(m) => out.extend(m.encode()),
Self::GossipTimestampFilter(m) => out.extend(m.encode()),
Self::Unknown { payload, .. } => out.extend(payload),
Expand Down Expand Up @@ -312,6 +320,9 @@ impl Message {
Ok(Self::UpdateFulfillHtlc(UpdateFulfillHtlc::decode(cursor)?))
}
msg_type::UPDATE_FAIL_HTLC => Ok(Self::UpdateFailHtlc(UpdateFailHtlc::decode(cursor)?)),
msg_type::COMMITMENT_SIGNED => {
Ok(Self::CommitmentSigned(CommitmentSigned::decode(cursor)?))
}
msg_type::UPDATE_FAIL_MALFORMED_HTLC => Ok(Self::UpdateFailMalformedHtlc(
UpdateFailMalformedHtlc::decode(cursor)?,
)),
Expand Down Expand Up @@ -726,6 +737,32 @@ mod tests {
assert_eq!(decoded, Message::UpdateFailHtlc(msg));
}

/// Valid `CommitmentSigned` message for testing.
fn sample_commitment_signed() -> CommitmentSigned {
let secp = Secp256k1::new();
let sk = SecretKey::from_byte_array([0x11; 32]).expect("valid secret");
let msg = secp256k1::Message::from_digest([0xaa; 32]);
let sig = secp.sign_ecdsa(msg, &sk);
let msg2 = secp256k1::Message::from_digest([0xbb; 32]);
let htlc_sig = secp.sign_ecdsa(msg2, &sk);

CommitmentSigned {
channel_id: ChannelId::new([0xab; CHANNEL_ID_SIZE]),
signature: sig,
htlc_signatures: vec![htlc_sig],
tlvs: CommitmentSignedTlvs::default(),
}
}

#[test]
fn message_commitment_signed_roundtrip() {
let cs = sample_commitment_signed();
let msg = Message::CommitmentSigned(cs.clone());
let encoded = msg.encode();
let decoded = Message::decode(&encoded).unwrap();
assert_eq!(decoded, Message::CommitmentSigned(cs));
}

#[test]
fn message_update_fail_malformed_htlc_roundtrip() {
let msg = UpdateFailMalformedHtlc {
Expand Down Expand Up @@ -871,6 +908,10 @@ mod tests {
.msg_type(),
msg_type::UPDATE_FAIL_HTLC
);
assert_eq!(
Message::CommitmentSigned(sample_commitment_signed()).msg_type(),
msg_type::COMMITMENT_SIGNED
);
assert_eq!(
Message::UpdateFailMalformedHtlc(UpdateFailMalformedHtlc {
channel_id: ChannelId::new([0x42; CHANNEL_ID_SIZE]),
Expand Down
Loading
Loading