Feat[#124] 특정 태스크의 모립세트 불러오기 by eunseo5343 · Pull Request #125 · morib-in/Morib-Server

eunseo5343 · 2024-07-17T12:21:41Z

📍 Issue

closes #124

✨ Key Changes

MsetApiController

Morib-Server/jaksim/src/main/java/org/sopt/jaksim/mset/api/MsetApiController.java

Lines 35 to 41 in 760e33d

    
               @GetMapping("/mset/tasks/{taskId}") 
        
               //@Override 
        
               public ResponseEntity<BaseResponse<?>> getFromOtherTask(@PathVariable("taskId") Long taskId) { 
        
                   TaskMsetLinkResponse response = taskMsetFacade.getFromOtherTask(taskId); 
        
                   return ApiResponseUtil.success(SuccessMessage.SUCCESS, response); 
        
               } 
        
           }

TaskMsetFacade

Morib-Server/jaksim/src/main/java/org/sopt/jaksim/category/facade/TaskMsetFacade.java

Lines 24 to 42 in 760e33d

    
           @Slf4j 
        
           @Service 
        
           @RequiredArgsConstructor 
        
           public class TaskMsetFacade { 
        
               private final TaskService taskService; 
        
               private final MsetService msetService; 
        
               private final TaskMsetService taskMsetService; 
        
               public TaskMsetLinkResponse getFromOtherTask(Long taskId) { 
        
                   Task task = taskService.getTaskById(taskId); 
        
                   List<TaskMset> taskMsetList = taskMsetService.getByTaskId(taskId); 
        
                   List<MsetDTO> msets = taskMsetList.stream() // 
        
                           .map(taskMset -> msetService.getMsetById(taskMset.getMsetId())) 
        
                           .map(mset -> new MsetDTO(mset.getId(), mset.getName(), mset.getUrl())) 
        
                           .collect(Collectors.toList()); 
        
                   return TaskMsetLinkResponse.of(task, msets); 
        
               } 
        
           }

TaskMsetRepository

Morib-Server/jaksim/src/main/java/org/sopt/jaksim/mset/repository/TaskMsetRepository.java

Lines 8 to 10 in 760e33d

    
           public interface TaskMsetRepository extends JpaRepository<TaskMset, Long> { 
        
               List<TaskMset> findByTaskId(Long taskId); 
        
           }

TaskService

Morib-Server/jaksim/src/main/java/org/sopt/jaksim/task/service/TaskService.java

Lines 69 to 72 in 760e33d

    
           public List<Task> getTasksByTodoTask(List<TodoTask> todoTaskList) { 
        
               List<Long> taskIdList = todoTaskList.stream().map(TodoTask::getTaskId).collect(Collectors.toList()); 
        
               return taskRepository.findAllById(taskIdList); 
        
           }

원래 있던거 사용..!

MsetSerive

Morib-Server/jaksim/src/main/java/org/sopt/jaksim/mset/service/MsetService.java

Lines 32 to 36 in 760e33d

    
               public Mset getMsetById(Long msetId) { 
        
                   return msetRepository.findById(msetId).orElseThrow( 
        
                           () -> new NotFoundException(ErrorMessage.NOT_FOUND) 
        
                   );    } 
        
           }

원래 있던거 사용..!

TaskMsetLinkResponse

Morib-Server/jaksim/src/main/java/org/sopt/jaksim/category/dto/TaskMsetLinkResponse.java

Lines 9 to 16 in 760e33d

    
           public record TaskMsetLinkResponse( 
        
                   Task task, 
        
                   List<MsetDTO> msets 
        
           ) { 
        
               public static TaskMsetLinkResponse of(Task task, List<MsetDTO> msets) { 
        
                   return new TaskMsetLinkResponse(task, msets); 
        
               } 
        
           }

MsetDTO

Morib-Server/jaksim/src/main/java/org/sopt/jaksim/mset/domain/MsetDTO.java

Lines 5 to 16 in 760e33d

    
           @Getter 
        
           public class MsetDTO { 
        
               private final Long id; 
        
               private final String name; 
        
               private final String url; 
        
               public MsetDTO(Long id, String name, String url) { 
        
                   this.id = id; 
        
                   this.name = name; 
        
                   this.url = url; 
        
               } 
        
           }

💬 To Reviewers

geniusYoo

꼼꼼하게 리뷰 달아드렸으니, 전부 확인 후 반응을 남겨주세요!

구현은 전체적으로 잘 하셨네요!
리팩토링만 하면 더욱 깔끔한 코드가 될 것 같아요! 👍🏻

geniusYoo · 2024-07-17T13:08:07Z

+import lombok.Getter;
+
+@Getter
+public class MsetDTO {


dto는 클라이언트와 controller 레벨에서 주고받는 객체의 형태입니다.

여기서 MsetDTO라는 객체는 TaskMsetLinkResponse 안의 mset 객체를 표현하기 위한 VO 인것으로 보여지는데요, 조금 더 적절한 이름으로 수정해보는 것은 어떨까요?

예를 들어, MsetInTask 같은 것이 있겠네요!

넵 의견 감사합니다

geniusYoo · 2024-07-17T13:10:09Z

+    private final String name;
+    private final String url;
+
+    public MsetDTO(Long id, String name, String url) {


TaskMsetLinkResponse의 형태처럼 정적 팩토리 메소드 패턴을 이용한 것이 아닌, 매개변수가 있는 생성자를 이용한 특별한 이유가 있을까요?

또한, 매개변수를 모두 파라미터로 받는 생성자를 작성할 때는 Lombok의 @AllArgsConstructor가 있기 때문에 코드를 더 간결하게 만들 수도 있겠네요!

geniusYoo · 2024-07-17T13:10:30Z

+import lombok.Getter;
+
+@Getter
+public class MsetDTO {


record가 아닌 class를 사용한 이유가 있을까요?

고치겠슴니다....

geniusYoo · 2024-07-17T13:13:42Z

+public class TaskMsetService {
+    private final TaskMsetRepository taskMsetRepository;
+    public List<TaskMset> getByTaskId(Long taskId) {
+        return taskMsetRepository.findByTaskId(taskId);


taskId가 존재하지 않는 경우를 핸들링해주는 코드가 필요할 것 같아요 !

Suggested change

return taskMsetRepository.findByTaskId(taskId);

taskMsetRepository.findByTaskId(taskId).orElseThrow(

() -> /* Error Handling */

)

추가적으로, orElseThrow()를 쓰려면 repository의 코드를 수정해야할텐데요 ! 같이 고민해보면 좋을 것 같네요 :)

아하 넵!

말씀해주신대로

taskMsetRepository.findByTaskId(taskId).orElseThrow( () -> new NotFoundException(ErrorMessage.NOT_FOUND) )

이렇게 바꾸고

repository는

Optional을 추가해줘야할 것 같군요!

geniusYoo · 2024-07-17T13:15:54Z

+        List<TaskMset> taskMsetList = taskMsetService.getByTaskId(taskId);
+        List<MsetDTO> msets = taskMsetList.stream() //
+                .map(taskMset -> msetService.getMsetById(taskMset.getMsetId()))
+                .map(mset -> new MsetDTO(mset.getId(), mset.getName(), mset.getUrl()))


이렇게 new 연산자로 객체를 무분별하게 만들지 않기 위해 우리는 패턴을 적용했었는데요 ...! 패턴을 적용해주면 좋을 것 같네요 :)

geniusYoo · 2024-07-17T13:18:02Z

+    public TaskMsetLinkResponse getFromOtherTask(Long taskId) {
+        Task task = taskService.getTaskById(taskId);
+        List<TaskMset> taskMsetList = taskMsetService.getByTaskId(taskId);
+        List<MsetDTO> msets = taskMsetList.stream() //


map을 두번 엮어서 간결하게 코드를 표현해주신 것 아주 좋네요 :) !!

geniusYoo · 2024-07-17T13:18:27Z

+
+import java.util.List;
+
+public record TaskMsetLinkResponse(


네이밍 좋네요 ! 👍🏻👍🏻

근데, TaskMsetLinkResponse에는 Task는 제외해도 됩니다 :) 모립세트만 포함되면 됩니다!

eunseo5343 added 8 commits July 17, 2024 21:10

Fix [#125] msetdto 수정

be1fc57

Feat [#125] TaskMsetFacade

bfb8366

Feat [#125] TaskMsetLinkResponse

97a1bf6

Feat [#125] TaskMsetReposotory

179a954

Feat [#125] TaskMsetService

c773c82

Feat [#125] TaskService수정

d7444a9

Feat [#125] MsetApiController 수정

042c65e

Feat [#125] 자잘한 오류 해결

760e33d

eunseo5343 self-assigned this Jul 17, 2024

eunseo5343 changed the title ~~Feat/#124~~ Feat[#124] 특정 태스크의 모립세트 불러오기 Jul 17, 2024

geniusYoo self-requested a review July 17, 2024 12:39

geniusYoo reviewed Jul 17, 2024

View reviewed changes

	@GetMapping("/mset/tasks/{taskId}")
	//@Override
	public ResponseEntity<BaseResponse<?>> getFromOtherTask(@PathVariable("taskId") Long taskId) {
	TaskMsetLinkResponse response = taskMsetFacade.getFromOtherTask(taskId);
	return ApiResponseUtil.success(SuccessMessage.SUCCESS, response);
	}
	}

	@Slf4j
	@Service
	@RequiredArgsConstructor
	public class TaskMsetFacade {
	private final TaskService taskService;
	private final MsetService msetService;
	private final TaskMsetService taskMsetService;

	public TaskMsetLinkResponse getFromOtherTask(Long taskId) {
	Task task = taskService.getTaskById(taskId);
	List<TaskMset> taskMsetList = taskMsetService.getByTaskId(taskId);
	List<MsetDTO> msets = taskMsetList.stream() //
	.map(taskMset -> msetService.getMsetById(taskMset.getMsetId()))
	.map(mset -> new MsetDTO(mset.getId(), mset.getName(), mset.getUrl()))
	.collect(Collectors.toList());
	return TaskMsetLinkResponse.of(task, msets);
	}

	}

	public interface TaskMsetRepository extends JpaRepository<TaskMset, Long> {
	List<TaskMset> findByTaskId(Long taskId);
	}

	public List<Task> getTasksByTodoTask(List<TodoTask> todoTaskList) {
	List<Long> taskIdList = todoTaskList.stream().map(TodoTask::getTaskId).collect(Collectors.toList());
	return taskRepository.findAllById(taskIdList);
	}

	public Mset getMsetById(Long msetId) {
	return msetRepository.findById(msetId).orElseThrow(
	() -> new NotFoundException(ErrorMessage.NOT_FOUND)
	); }
	}

	public record TaskMsetLinkResponse(
	Task task,
	List<MsetDTO> msets
	) {
	public static TaskMsetLinkResponse of(Task task, List<MsetDTO> msets) {
	return new TaskMsetLinkResponse(task, msets);
	}
	}

	@Getter
	public class MsetDTO {
	private final Long id;
	private final String name;
	private final String url;

	public MsetDTO(Long id, String name, String url) {
	this.id = id;
	this.name = name;
	this.url = url;
	}
	}

-        return taskMsetRepository.findByTaskId(taskId);
+taskMsetRepository.findByTaskId(taskId).orElseThrow(
+   () -> /* Error Handling */
+)

Conversation

eunseo5343 commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📍 Issue

✨ Key Changes

MsetApiController

TaskMsetFacade

TaskMsetRepository

TaskService

MsetSerive

TaskMsetLinkResponse

MsetDTO

💬 To Reviewers

Uh oh!

geniusYoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geniusYoo Jul 17, 2024 • edited by eunseo5343 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eunseo5343 Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eunseo5343 commented Jul 17, 2024 •

edited

Loading

geniusYoo Jul 17, 2024 •

edited by eunseo5343

Loading

eunseo5343 Jul 18, 2024 •

edited

Loading