Feat[#124] 특정 태스크의 모립세트 불러오기 #125
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package org.sopt.jaksim.category.dto; | ||
|
|
||
| import org.sopt.jaksim.mset.domain.Mset; | ||
| import org.sopt.jaksim.mset.domain.MsetDTO; | ||
| import org.sopt.jaksim.task.domain.Task; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public record TaskMsetLinkResponse( | ||
| Task task, | ||
| List<MsetDTO> msets | ||
| ) { | ||
| public static TaskMsetLinkResponse of(Task task, List<MsetDTO> msets) { | ||
| return new TaskMsetLinkResponse(task, msets); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package org.sopt.jaksim.category.facade; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.sopt.jaksim.category.domain.Category; | ||
| import org.sopt.jaksim.category.dto.CategoryMsetLinkResponse; | ||
| import org.sopt.jaksim.category.dto.TaskMsetLinkResponse; | ||
| import org.sopt.jaksim.category.service.CategoryService; | ||
| import org.sopt.jaksim.mset.domain.CategoryMset; | ||
| import org.sopt.jaksim.mset.domain.Mset; | ||
| import org.sopt.jaksim.mset.domain.MsetDTO; | ||
| import org.sopt.jaksim.mset.domain.TaskMset; | ||
| import org.sopt.jaksim.mset.service.CategoryMsetService; | ||
| import org.sopt.jaksim.mset.service.MsetService; | ||
| import org.sopt.jaksim.mset.service.TaskMsetService; | ||
| import org.sopt.jaksim.task.domain.Task; | ||
| import org.sopt.jaksim.task.service.TaskService; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| @Slf4j | ||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class TaskMsetFacade { | ||
| private final TaskService taskService; | ||
| private final MsetService msetService; | ||
| private final TaskMsetService taskMsetService; | ||
|
|
||
| public TaskMsetLinkResponse getFromOtherTask(Long taskId) { | ||
| Task task = taskService.getTaskById(taskId); | ||
| List<TaskMset> taskMsetList = taskMsetService.getByTaskId(taskId); | ||
| List<MsetDTO> msets = taskMsetList.stream() // | ||
|
Contributor
There was a problem hiding this comment. map을 두번 엮어서 간결하게 코드를 표현해주신 것 아주 좋네요 :) !! |
||
| .map(taskMset -> msetService.getMsetById(taskMset.getMsetId())) | ||
| .map(mset -> new MsetDTO(mset.getId(), mset.getName(), mset.getUrl())) | ||
|
Contributor
There was a problem hiding this comment. 이렇게 |
||
| .collect(Collectors.toList()); | ||
| return TaskMsetLinkResponse.of(task, msets); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package org.sopt.jaksim.mset.domain; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class MsetDTO { | ||
|
Contributor
There was a problem hiding this comment. dto는 클라이언트와 controller 레벨에서 주고받는 객체의 형태입니다. 여기서 예를 들어,
Contributor
There was a problem hiding this comment. record가 아닌 class를 사용한 이유가 있을까요? |
||
| private final Long id; | ||
| private final String name; | ||
| private final String url; | ||
|
|
||
| public MsetDTO(Long id, String name, String url) { | ||
|
Contributor
There was a problem hiding this comment. TaskMsetLinkResponse의 형태처럼 정적 팩토리 메소드 패턴을 이용한 것이 아닌, 매개변수가 있는 생성자를 이용한 특별한 이유가 있을까요? 또한, 매개변수를 모두 파라미터로 받는 생성자를 작성할 때는 Lombok의 @AllArgsConstructor가 있기 때문에 코드를 더 간결하게 만들 수도 있겠네요! |
||
| this.id = id; | ||
| this.name = name; | ||
| this.url = url; | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package org.sopt.jaksim.mset.repository; | ||
|
|
||
| import org.sopt.jaksim.mset.domain.TaskMset; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public interface TaskMsetRepository extends JpaRepository<TaskMset, Long> { | ||
| List<TaskMset> findByTaskId(Long taskId); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,21 @@ | ||||||||||
| package org.sopt.jaksim.mset.service; | ||||||||||
|
|
||||||||||
| import lombok.RequiredArgsConstructor; | ||||||||||
| import lombok.extern.slf4j.Slf4j; | ||||||||||
| import org.sopt.jaksim.mset.domain.CategoryMset; | ||||||||||
| import org.sopt.jaksim.mset.domain.TaskMset; | ||||||||||
| import org.sopt.jaksim.mset.repository.CategoryMsetRepository; | ||||||||||
| import org.sopt.jaksim.mset.repository.TaskMsetRepository; | ||||||||||
| import org.springframework.stereotype.Service; | ||||||||||
|
|
||||||||||
| import java.util.List; | ||||||||||
|
|
||||||||||
| @Slf4j | ||||||||||
| @Service | ||||||||||
| @RequiredArgsConstructor | ||||||||||
| public class TaskMsetService { | ||||||||||
| private final TaskMsetRepository taskMsetRepository; | ||||||||||
| public List<TaskMset> getByTaskId(Long taskId) { | ||||||||||
| return taskMsetRepository.findByTaskId(taskId); | ||||||||||
|
Contributor
There was a problem hiding this comment. taskId가 존재하지 않는 경우를 핸들링해주는 코드가 필요할 것 같아요 !
Suggested change
Contributor
There was a problem hiding this comment. 추가적으로,
Contributor
Author
There was a problem hiding this comment. 말씀해주신대로 taskMsetRepository.findByTaskId(taskId).orElseThrow(
() -> new NotFoundException(ErrorMessage.NOT_FOUND)
)이렇게 바꾸고 repository는 Optional을 추가해줘야할 것 같군요! |
||||||||||
| } | ||||||||||
| } | ||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네이밍 좋네요 ! 👍🏻👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
근데, TaskMsetLinkResponse에는 Task는 제외해도 됩니다 :) 모립세트만 포함되면 됩니다!