Skip to content

Update ArcBallCamera.h #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ttnghia wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update ArcBallCamera.h #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f347f3
Update ArcBallCamera.h
ttnghia Jul 5, 2020
bdf51f7
Update ArcBallCamera.h
ttnghia Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/arcball/ArcBallCamera.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,16 @@ class ArcBallCamera: public ArcBall {
SceneGraph::Scene<Transformation>& scene,
const Vector3& cameraPosition, const Vector3& viewCenter,
const Vector3& upDir, Deg fov, const Vector2i& windowSize,
const Vector2i& viewportSize):
const Vector2i& viewportSize,
Float near = 0.01f, Float far = 100.0f):
ArcBall{cameraPosition, viewCenter, upDir, fov, windowSize}
{
/* Create a camera object of a concrete type */
auto* cameraObject = new SceneGraph::Object<Transformation>{&scene};
(*(_camera = new SceneGraph::Camera3D{*cameraObject}))
.setAspectRatioPolicy(SceneGraph::AspectRatioPolicy::Extend)
.setProjectionMatrix(Matrix4::perspectiveProjection(
fov, Vector2{windowSize}.aspectRatio(), 0.01f, 100.0f))
fov, Vector2{windowSize}.aspectRatio(), near, far))
.setViewport(viewportSize);

/* Save the abstract transformation interface and initialize the
Expand Down