Repository navigation
Ding! - Dungeon quests: one guide per dungeon and side (v1.7.0) - #55
Merged
Merged
Conversation
…side Registers "Ding! - Dungeon quests" (ding-dungeons, builtin 5, category "dungeon"): the Guide tab lists the character's side only, by level. A go step at a dungeon's entrance now passes once the character is inside an instance, where the game gives no position (Compat.InInstance, Data:DungeonAtEntrance, checked on PLAYER_ENTERING_WORLD). check_guides knows the pack and its category. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks the dungeon's quests open to the side, their prerequisites, breadcrumbs, drop-started quests and follow-ups, places each action before, inside or after the dungeon, and orders the trips with route_travel. Raids, set chains, professions, repeatables and long class chains are left out and listed in a report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Classic dungeons from Ragefire Chasm to Stratholme, Lower Blackrock Spire included, and Forever's Hall of Thanes, Ruins of Lordaeron, Excavation Site: Wetlands and City of Dalaran: the quest givers and their chains, the entrance, one step per objective with a note saying where, then the turn-ins and follow-ups. dungeon_quests_test covers the pack, the section list, the assistant, the entrance passed from inside and the data; the smoke test expects the new header. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SPEC and guide-packs describe the "dungeon" category and the entrance step passed from inside an instance; architecture, CLAUDE.md and the tools README list the guides and draft_dungeon.lua; README gains the feature line and CHANGELOG the v1.7.0 entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
874 texts added to each tools/routes/locales dictionary (frFR, deDE, esES, ptBR, koKR, zhCN, zhTW); translate_guides.lua writes the 287 guide translations and their TOC lines. Names the game has no translation for (Forever's NPCs, quests and items) stay in English. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-c75de0 # Conflicts: # CHANGELOG.md
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New built-in pack Ding! - Dungeon quests (
ding-dungeons, categorydungeon), for v1.7.0:one guide per dungeon and side. Each guide takes the character to every quest giver of the
dungeon (with the chains that lead there, from where they start) in an order that keeps the
trips short, then to the entrance, then inside with one step per objective and a note saying
where it is and which boss or monster drops what (the arrow does not work inside), then to the
turn-ins and the follow-ups they open.
from Ragefire Chasm / the Deadmines to Stratholme, Scholomance, Lower Blackrock Spire and
Dire Maul, plus Forever's own: the Hall of Thanes, the Ruins of Lordaeron, Excavation Site:
Wetlands, the City of Dalaran.
level; dungeons above the character's level are greyed but can still be picked. Picking the
pack takes the dungeon of the character's level (
Ding:SuggestGuide); the setup assistantoffers it like the other packs.
whywhat it brings (an item forwhich kind of character, a big experience reward), whether it is long, far, elite or a group
fight. Very long or far chains are optional on every step and say why. Quests a drop starts
only show when the item is in the bags.
gostep at a dungeon's entrance now also passes once the character is insidean instance, where the game gives no position (
Compat.InInstance,Data:DungeonAtEntrance, checked onPLAYER_ENTERING_WORLD).tools/draft_dungeon.luadrafts a dungeon's guide for a side from the export(selection, chains, before/inside/after placement, trip order through
route_travel); theguides were finished by hand from those drafts.
tools/routes/localesandtranslate_guides.lua.tools/README, README feature line, CHANGELOG v1.7.0.
Left out (and why)
Dawn's Gambit which needs UBRS eggs), the level 60 armor-set chains (8900-9025, Valthalak),
Dire Maul class books and librams, Quel'Serrar: raid or end-game set content.
Sparklematic cleaning quests...).
class quests of the Sunken Temple...): Ding! - Class quests leads them.
ender is unknown are optional (95809, 95795).
To check in game
(taken from their quests), the forge of 92753.
Test plan
tools/check_guides.lua: 0 errors, 0 warningstools/tests/dungeon_quests_test.lua(pack, sides and level order, section list,assistant, entrance passed from inside, a note on every step inside, data, translations)
tools/smoke_test.lua --only dungeon-: 0 problemsbash tools/check_all.sh: ALL GREEN🤖 Generated with Claude Code