Repository navigation
Release v1.6.1 (gamepad hotfix) - #56
Merged
Merged
Conversation
The frames that read the gamepad first (the chord watcher while a chord's first button is held, a Ding window's) relied on the handler's return value to let a button through; the client reads the frame's input propagation instead, so every button was kept: with RB held for RB + Up, LB + RB + Left / Right (action bar pages) and + Down (chat) did nothing. Each handler now sets the propagation for the button it read (out of combat), and the mock client does the same as the game. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix v1.6.1: v1.6.0 plus the gamepad fix only.
With RB held (the first button of the default chord RB + Up), Ding's chord watcher kept every gamepad button from the game: LB + RB + D-pad (action bar pages, chat) and other bindings using RB did nothing (reported by the user and a tester with a PlayStation controller). The frames that read the gamepad first relied on the handler's return value; the client reads the frame's input propagation. Each handler now sets it for the button it read (out of combat); the mock client does the same as the game; a test reproduces the report.
Checks: tools/check_all.sh ALL GREEN (79 test files, 12 smoke runs). The same fix is in the v1.7.0 release branch.
🤖 Generated with Claude Code