Repository navigation
Arrow: say the target's floor (step key floor) - #57
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In game, the arrow said "You're here" in the middle of a building while the NPC was one floor up. The client gives addons no height for a target, but the guides' notes already say the floor. This PR adds that as a step key and has the arrow say it in words.
What the player sees
floor, the distance line says "The NPC is one floor up" / "The NPC is at the top" / "The NPC is one floor down" instead of "You're here". For an object, a place or a monster it says "It's one floor up"... The arrow no longer fades after 3 s on such a step, because the player still has to find the stairs. If the previous step had already faded at the same spot, the arrow comes back.gopoint.The key
floor = "up" | "top" | "down". It is in the public contract (docs/guide-packs.md,docs/create-a-guide-with-ai.md), SPEC,Import.STEP_KEYS(the value is checked),tools/check_guides.lua(a bad value is an error; a note that names a floor its key does not say is a warning) and the example pack (Aldrassil trainer).tools/guide_floor.lua: an explicit table of English phrases plus an ambiguity list. A note that names two floors, or a floor that may not be the right one, gets no key.write_leveling.luawrites the key from the route notes, so the routes stay the single source. It never goes on agostep, because its point is the door and its note describes the next step.Tests
floor_test(10 tests): arrival with and withoutfloor, the fade, the near-target hint, NPC vs object wording, the faded-then-floor case, locales, import, check_guides, the phrase table, and every Leveling or class step whose note names a floor carrying it.tools/check_all.sh: ALL GREEN (81 files, 12 smoke runs). Rebased on the 6 / 25 / 40 arrival thresholds.🤖 Generated with Claude Code