Repository navigation
Release v1.8.0 - #61
Merged
Merged
Conversation
The guide window's flag (beside the NPC directory's pin, reached up from the
pin in focus mode), the DING_REPORT binding and its chord, and /ding bug open
a Ding window that shows in plain words what the report will contain: the
guide, the step as the window numbers it and its index in the guide's file,
its summary and keys, the position, the character, the step's quests and the
log's quests the next 3 steps name with their counters, the arrow's target,
the route settings, the theme, TomTom, the versions and the date (UTC). Never
the character's name, the realm or the account.
Four ready reasons for a gamepad, the player's words with a keyboard (the box
never takes the keyboard from the chat), then "Create the text": GitHub
Markdown with English labels, selected for Ctrl+C, with the issue form's link.
The last 20 reports stay in DingDB.reports ("Restore all defaults" keeps
them) for a player who can only send the file.
Tests: report_test, the report window in dialog_layout_test and
single_action_test (every language, gamepad and mouse), a smoke scenario
with the gamepad alone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
.github/ISSUE_TEMPLATE/ding-report.yml: "Paste the text Ding made here" and "What happened?". README: the feature, /ding bug and how to report a problem. CHANGELOG: the v1.8.0 entry. SPEC, architecture and UI handoff: the window, the text, DingDB.reports, the flag in focus mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yendi: players must notice the button and feel invited to press it, and it must read as a problem with the guide, not a technical bug report. The flag now sits on a warm fill of its own in every theme (tokens report and onReport: Halo and Ardoise #FF6A3D, Bandes #FF7A50, Ding dark #FF7043; the flag at 6.5:1 or more on it, the fill at 6.5:1 or more on the window, unlike the accent), a lighter veil under the mouse, its tooltip in words: "Problem with this step?" and a line under it. The window's title and the binding: "Report a problem with the guide". No player-facing text says "bug" (the /ding bug command apart). Icon only: a word on it would cut the guide's title at the window's usual widths. Tests: every theme's fill, ink, contrast and focus ring; the tooltip; no "bug" in the report texts of the 8 languages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yendi, in game: the address first ("1. Open this address on GitHub:"),
selected first with its button on the left, then the text ("2. Copy this
text and paste it into the report:"), then how to copy and where the
reports are kept. The address was cut in its box ("...ding-repor"): 475
units in Noto Sans at 11 for a 488-unit box. It is now in 10 (432) and the
window is 560 wide like the import window (a 528-unit box).
Tests: the order, the buttons' order and chips, the address's width read
from the shipped font's own metrics.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s leaves Yendi, in game: the focused "Select the text" showed "A Y Select the text". A focused button now carries A alone; its own key (Y) comes back once the focus leaves, and still works meanwhile. Each button keeps room for the wider of the two chips, so nothing moves with the focus. single_action_test: no control of the report window shows two glyphs, at every stop, under the mouse, in every language; report_test: the chips and the width of "Select the text" focused and not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ayer" is a heading) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The mock's default player name, "Player", is also a heading of the report: the check that the character's name is not in the text failed on the heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.8.0: integrates #60 (Problem with this step?: a report window and a ready-to-paste text for GitHub issues, with the issue form .github/ISSUE_TEMPLATE/ding-report.yml), on top of v1.7.1.
Tested in game by the user (link above the text, the whole address shown, one glyph per button). The smoke test's privacy check now uses a player name of its own (the mock's "Player" is also a heading of the report).
Checks: tools/check_all.sh ALL GREEN (83 test files, 12 smoke runs), release_test green, DingDB unchanged. Installed in game.
🤖 Generated with Claude Code