Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
beatrice-acasandrei
self-requested a review
September 16, 2026 05:29
| <Grid container sx={titleContainerSx}> | ||
| <SubtestsBreadcrumbs view={view} /> | ||
| {testVersion === STUDENT_T && ( | ||
| <Grid component='h2' className={styles.replicates}> |
Contributor
There was a problem hiding this comment.
Using component='h2' makes the Grid render as an <h2> HTML element, but here it's just a layout wrapper for a button, not a section title
Suggested change
| <Grid component='h2' className={styles.replicates}> | |
| <Grid className={styles.replicates}> |
|
|
||
| const titleContainerSx = { | ||
| alignItems: 'center', | ||
| gap: '9px', |
Contributor
There was a problem hiding this comment.
MUI spacing unit, consistent with the rest of the codebase
Suggested change
| gap: '9px', | |
| gap: 1, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Introduced
Please review: @beatrice-acasandrei @esanuandra @kala-moz
Fixes Bug-1982588