Skip to content

Bug-1982588: Align breadcrumbs and replicates button in Subtests View #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moijes12 wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −22
Draft

Bug-1982588: Align breadcrumbs and replicates button in Subtests View #1102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13618d8
Bug 1982588: Align breadcrumbs and replicates button on the same line…
moijes12 Sep 10, 2026
c501abe
Bug 1982588: Align breadcrumbs and replicates button on the same line…
moijes12 Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/__tests__/CompareResults/__snapshots__/SubtestsResultsView.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,10 @@ exports[`SubtestsResultsView Component Tests should render the subtests results
>
<header>
<div
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row MuiGrid-spacing-xs-1 css-1ewzjrk-MuiGrid-root"
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row css-cv4vpp-MuiGrid-root"
>
<nav
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-12zd3mg-MuiTypography-root-MuiBreadcrumbs-root"
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-233p9k-MuiTypography-root-MuiBreadcrumbs-root"
>
<ol
class="MuiBreadcrumbs-ol css-1uwp4ue-MuiBreadcrumbs-ol"
Expand Down Expand Up @@ -2391,10 +2391,10 @@ exports[`SubtestsViewCompareOverTime Component Tests in mann-whitney-u testVersi
>
<header>
<div
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row MuiGrid-spacing-xs-1 css-1ewzjrk-MuiGrid-root"
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row css-cv4vpp-MuiGrid-root"
>
<nav
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-12zd3mg-MuiTypography-root-MuiBreadcrumbs-root"
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-233p9k-MuiTypography-root-MuiBreadcrumbs-root"
>
<ol
class="MuiBreadcrumbs-ol css-1uwp4ue-MuiBreadcrumbs-ol"
Expand Down Expand Up @@ -3932,10 +3932,10 @@ exports[`SubtestsViewCompareOverTime Component Tests in mann-whitney-u testVersi
>
<header>
<div
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row MuiGrid-spacing-xs-1 css-1ewzjrk-MuiGrid-root"
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row css-cv4vpp-MuiGrid-root"
>
<nav
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-12zd3mg-MuiTypography-root-MuiBreadcrumbs-root"
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-233p9k-MuiTypography-root-MuiBreadcrumbs-root"
>
<ol
class="MuiBreadcrumbs-ol css-1uwp4ue-MuiBreadcrumbs-ol"
Expand Down Expand Up @@ -5473,10 +5473,10 @@ exports[`SubtestsViewCompareOverTime Component Tests renders over-time view when
>
<header>
<div
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row MuiGrid-spacing-xs-1 css-1ewzjrk-MuiGrid-root"
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row css-cv4vpp-MuiGrid-root"
>
<nav
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-12zd3mg-MuiTypography-root-MuiBreadcrumbs-root"
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-233p9k-MuiTypography-root-MuiBreadcrumbs-root"
>
<ol
class="MuiBreadcrumbs-ol css-1uwp4ue-MuiBreadcrumbs-ol"
Expand Down Expand Up @@ -7014,10 +7014,10 @@ exports[`SubtestsViewCompareOverTime Component Tests should render the subtests
>
<header>
<div
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row MuiGrid-spacing-xs-1 css-1ewzjrk-MuiGrid-root"
class="MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row css-cv4vpp-MuiGrid-root"
>
<nav
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-12zd3mg-MuiTypography-root-MuiBreadcrumbs-root"
class="MuiTypography-root MuiTypography-body1 MuiBreadcrumbs-root css-233p9k-MuiTypography-root-MuiBreadcrumbs-root"
>
<ol
class="MuiBreadcrumbs-ol css-1uwp4ue-MuiBreadcrumbs-ol"
Expand Down
7 changes: 1 addition & 6 deletions src/components/CompareResults/SubtestsResults/SubtestsBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,7 @@ function SubtestsBreadcrumbs({ view }: SubtestsBreadcrumbsProps) {
: getPreviousCompareOverTimeURL();

return (
<Breadcrumbs
separator={<ChevronLeftIcon fontSize='small' />}
sx={{
marginBottom: 3,
}}
>
<Breadcrumbs separator={<ChevronLeftIcon fontSize='small' />}>
<span role='presentation'></span>
<Link href='/'>Home</Link>
<Link href={allResultsURL}>All results</Link>
Expand Down
22 changes: 16 additions & 6 deletions src/components/CompareResults/SubtestsResults/SubtestsResultsMain.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,16 @@ function SubtestsResultsMain({ view }: SubtestsResultsMainProps) {
marginBottom: Spacing.Medium,
fontSize: '16px',
}),
replicates: style({
marginRight: '10px',
}),
};

const titleContainerSx = {
alignItems: 'center',
gap: '9px',

@beatrice-acasandrei beatrice-acasandrei Sep 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUI spacing unit, consistent with the rest of the codebase

Suggested change
gap: '9px',
gap: 1,

margin: `0 0 ${Spacing.Medium}px 0`,
justifyContent: 'space-between',
};

const onSearchTermChange = (newSearchTerm: string) => {
Expand All @@ -158,14 +168,14 @@ function SubtestsResultsMain({ view }: SubtestsResultsMainProps) {
return (
<Container className={styles.container} data-testid='subtests-main'>
<header>
<Grid container spacing={1}>
<Grid container sx={titleContainerSx}>
<SubtestsBreadcrumbs view={view} />
{testVersion === STUDENT_T && (
<Grid component='h2' className={styles.replicates}>

@beatrice-acasandrei beatrice-acasandrei Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using component='h2' makes the Grid render as an <h2> HTML element, but here it's just a layout wrapper for a button, not a section title

Suggested change
<Grid component='h2' className={styles.replicates}>
<Grid className={styles.replicates}>

<ToggleReplicatesButton />
</Grid>
)}
</Grid>
{testVersion === STUDENT_T && (
<Grid sx={{ marginRight: '10px' }}>
<ToggleReplicatesButton />
</Grid>
)}
{displayMannWhitneyUWarning && (
<Alert
severity='warning'
Expand Down