fix(tools): agree verb number in the SELF-HOSTED.md not-covered sentence - #435
Merged
Merged
Conversation
przecinki() already returned a bare name for a one-element list, but the
sentence around it was hardcoded plural ("are in the same position...
They are missing"). Wiki.js landing in data/apps.json (#434) shrank the
uncovered list to one entry (Portainer) and exposed it: "Portainer are
in the same position" instead of "is". zdanie_nieobjete() now agrees
is/It with are/They based on list length.
msgwing
enabled auto-merge (squash)
September 10, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
przecinki()in tools/build-app-pages.py already collapses a one-elementlist to a bare name, but the sentence built around it in
zbuduj_indeks() was hardcoded plural: "... are in the same position and
are not covered yet. They are missing ...". After Wiki.js was added to
data/apps.json (#434), the uncovered list shrank to a single entry
(Portainer), and docs/SELF-HOSTED.md started reading:
Portainer are in the same position and are not covered yet.
Fix
Added zdanie_nieobjete(), which builds that sentence and picks
is/It vs are/They based on len(nieobjete), then regenerated
docs/SELF-HOSTED.md from data/apps.json.
Test plan