Skip to content

fix(ci): board-review and changes need full history, not fetch-depth 2 - #446

Merged
msgwing merged 1 commit into
mainfrom
ci/board-review-fetch-depth
Sep 20, 2026
Merged

msgwing merged 1 commit into
mainfrom
ci/board-review-fetch-depth

Conversation

@msgwing

@msgwing msgwing commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Problem

PR #436 sat BLOCKED for 10 days (2026-09-10 to 2026-09-20). board-review
was crashing, not failing on content:

subprocess.CalledProcessError: Command ['git', 'diff', '--name-only',
'<base-sha>', '<head-sha>'] returned non-zero exit status 128.

board-review and changes both check out with fetch-depth: 2, on the
assumption (documented in the comment above board-review) that a
pull_request event's github.sha is a merge commit one hop ahead of the
real head, so depth 2 reaches both the head and the base. That holds only
while the branch is at most ~1 commit past its base. PR #436 picked up a
second and third push (a missed regeneration, then a retrigger) after
opening, so its base sha fell outside the shallow history and git diff
failed outright with "bad revision" - not a lint failure, a crash, which
still shows as a red required check and blocks merge exactly as if it were.

changes runs the identical git diff base head, on the identical
assumption, and has not hit this yet only because no branch happened to
reach 3 commits while it mattered.

Fix

fetch-depth: 0 (full history) on both checkouts. Small cost, and the
comment explaining the old depth-2 reasoning is corrected in place rather
than deleted quietly.

Test plan

BOARD: MERGE - the merge path itself was silently blocking a real PR for 10 days; this is a correctness fix to an existing gate, not a new one.
EVIDENCE: python .github/check-workflows.py clean; root cause reproduced against PR #436's job log (git diff --name-only 4242a8d... 13947af9... exit 128, both shas confirmed present on main/the PR branch, so the failure is shallow-history-only, not a real missing commit).

PR #436 sat BLOCKED for 10 days (2026-09-10 -> 2026-09-20): board-review
crashed with 'git diff base head' exit 128 once the branch picked up a third
commit past its base sha, because fetch-depth 2 only reaches one commit back
from the merge commit. changes has the identical base/head diff and the same
latent bug, just not yet hit. Both now fetch full history.
@msgwing
msgwing enabled auto-merge (squash) September 20, 2026 12:20
@github-actions github-actions Bot added the ci label Sep 20, 2026
@msgwing
msgwing merged commit b1b1baa into main Sep 20, 2026
40 checks passed
@msgwing
msgwing deleted the ci/board-review-fetch-depth branch September 20, 2026 12:21
msgwing added a commit that referenced this pull request Sep 20, 2026
#436)

* docs(alternatives): re-measure the self-hosted proxy shelf, 2026-09-10

Re-ran the 2026-08-27 competitive scan against GitHub directly instead of
memory. Two of five previously-listed projects are still dead, one
(JustinIven/smtp-oauth-relay) turns out to have been credited with commits
that were actually an unmerged dependabot branch - its real last commit is
three weeks older than pushed_at suggested. Adds two projects the prior scan
missed: rustmailer/rustmailer (504 stars, active, broader scope) and
debold/GraphMailer.NET (2 stars, but the most actively developed project on
the shelf and the closest match to our own audience of legacy printers and
scanners).

* chore: regenerate llms-full.txt for the alternatives-shelf refresh

* chore: retrigger checks after PR body board-review fix

* chore: retrigger checks after fetch-depth fix (#446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant