fix(devices): correct broken contributor attribution links - #454
Merged
Merged
Conversation
Zabbix and Xerox entries pointed contributor_pr at the issue number (289, 408) instead of the merged PR (369, 416) - GitHub redirects /pull/<issue-number> to /issues/<issue-number>, so the public credit line linked to the discussion thread, not the shipped diff. Confirmed live with curl: 289 and 408 return 302 to /issues/, 369 and 416 return 200 as pull requests. TrueNAS had no contributor field at all, despite #288's closing comment naming Mohitingale13 and PR #368. No vendor-facing claim changed; regenerated via tools/build-device-table.py and tools/build-data-endpoints.py, both --check clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOARD: MERGE - restores correct public credit to two contributors whose links silently pointed at the wrong thread; no vendor-facing claim changes.
EVIDENCE: curl -sI on all eight contributor_pr links in data/devices.json - 289 and 408 returned 302 to /issues/ (wrong: those are the issue numbers), 369 and 416 returned 200 as pull requests (the actual merges); the other six already resolved 200. tools/build-device-table.py --check and tools/build-data-endpoints.py --check both clean after regeneration. tools/check-facts.py: 5 shared claims, no page contradicts one.
What was wrong
Found while auditing the "good first issue" funnel for external-contributor
health:
data/devices.jsonrenders a public credit line on each generateddevice page (
tools/build-device-table.py, "entry contributed by @user in#N"). Three of eight entries had a broken or missing version of it.
contributor_pr: 289) and Xerox (contributor_pr: 408)both pointed at the issue number, not the PR that actually shipped the
entry (
#369and#416). GitHub redirects/pull/<n>to/issues/<n>when
nis an issue, so both public pages linked a reader to thediscussion, not the diff. Confirmed live, not assumed - see EVIDENCE.
contributor/contributor_prfield at all, despiteAdd TrueNAS to the OAuth compatibility list (needs one vendor link) #288's own closing comment crediting Mohitingale13 and PR docs: add TrueNAS email alert OAuth compatibility #368. The page
carried zero attribution.
Change
Corrected the two wrong PR numbers, added the missing TrueNAS attribution,
regenerated every derived file (
docs/devices/*.md,docs/data/devices.json,packages/zerosmtp-mcp/data/devices.json) via the existing generators - nonehand-edited.