Add marketdata to the server's clone, install and upgrade steps - #27
Merged
Conversation
The previous change declared the dependency and documented the store, and left the deploy broken. requirements.txt now carries `-e ../marketdata`, but the setup steps clone and install only cotdata, cotmetrics and cot-analyzer, so a fresh deploy fails at `pip install -r requirements.txt` with "Distribution not found at: file:///root/trading_workspace/marketdata" — an error that names a path rather than the missing clone. marketdata is the one sibling that cannot fall back to an index: cotdata and cotmetrics are both on PyPI, marketdata is not, so the checkout is the only way to resolve it. Said explicitly where the clone list is, rather than left to be inferred from a failed install. The upgrade block gains it too, with the reason the "pull all of them or none" rule now extends: cotmetrics calls marketdata.get_bars and marketdata.schema_version, so a stale marketdata checkout is a price failure inside a COT deployment that otherwise looks healthy. Found by reading the deploy path after merging, which is where it should have been checked before. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jo4iovRfc2fzE9MwcLp7r2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26. That PR left the server deploy broken, and this fixes it.
#26 added
-e ../marketdatatorequirements.txtand documentedMARKETDATA_STORE, but the setup steps inserver-side/README.mdclone and install onlycotdata,cotmetricsandcot-analyzer. So a fresh deploy now fails atpip install -r requirements.txtwith:— an error that names a path rather than the missing clone.
What changes
marketdata, with a note that it is the one sibling that cannot fall back to an index.cotdataandcotmetricsare both on PyPI;marketdatais not, so the checkout is the only thing that resolves it. Stated where the clone list is rather than left to be inferred from a failed install.pip install -e ../marketdata— "three serving repos" is now four.git pull, and the "pull all of them or none" rule gains its reason for the new member:cotmetricscallsmarketdata.get_barsandmarketdata.schema_version, so a stalemarketdatacheckout is a price failure inside a COT deployment that otherwise looks healthy.How this was missed
I documented the store (
MARKETDATA_STORE, the rsync push, the troubleshooting symptom) and the dependency declaration, then stopped — I read the env-var and sync sections and not the install section. Found by reading the deploy path after merging, which is where it should have been checked before.Docs only; no code changes, so CI covers the same ground it did on #26.
Generated by Claude Code