Depend on crucible-marketdata, and check its floor by that name - #28
Merged
Conversation
… by that name marketdata publishes as `crucible-marketdata`, because `marketdata` on PyPI belongs to an unrelated abandoned project. A dependency names the DISTRIBUTION, so both the declared dep and check_dep_floors' INTERNAL set follow. The floor check matters here more than the declaration does: it exists precisely because editable siblings install at whatever HEAD was checked out and pip never enforces the declared floor, and a name it does not recognise is a floor it silently stops checking. The import name is unchanged, and nothing in this repo imports it anyway — cotmetrics does. Verified in a clean venv: floors OK for all three, 131 tests pass, ruff clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jo4iovRfc2fzE9MwcLp7r2
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to mspinola/marketdata#9, which publishes that package as
crucible-marketdata—marketdataon PyPI belongs to an unrelated, abandoned project.A dependency names the distribution, so both the declared dep and
check_dep_floors.py'sINTERNALset follow.The floor check matters more here than the declaration does. It exists precisely because editable siblings install at whatever HEAD was checked out and pip never enforces the declared floor — so a name it does not recognise is a floor it silently stops checking. That is the failure this repo built the script to prevent.
The import name is unchanged, and nothing in this repo imports it anyway — cotmetrics does.
Verified in a clean venv
131 tests pass, ruff clean over
srcandtests.Note on #27
#27 (server clone/install steps) is still open and touches the same file region in
server-side/README.md. Merge #27 first; this one does not conflict with it, but the deploy instructions there saypip install -e ../marketdata, which stays correct — an editable install resolves by path, not by distribution name.Land with mspinola/marketdata#9 and mspinola/cotmetrics#12 — the three are one change.
Generated by Claude Code