Depend on crucible-marketdata, the distribution name - #12
Merged
Conversation
marketdata publishes as `crucible-marketdata` because `marketdata` on PyPI is an unrelated, abandoned project. A dependency names the DISTRIBUTION, so this had to follow: left as `marketdata>=0.1.0` it would either fail to resolve against the editable sibling or, worse, succeed by fetching a stranger's 2020 module. The import is untouched. Every call site still says `import marketdata`, which is the whole reason the distribution was renamed instead of the package. Verified in a clean venv rather than the working one. The working venv had a stale `marketdata` dist-info beside the new `crucible-marketdata`, so `pip check` passed on a leftover and proved nothing; from scratch, only crucible-marketdata installs, `import marketdata` resolves, and 238 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jo4iovRfc2fzE9MwcLp7r2
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to mspinola/marketdata#9, which publishes that package as
crucible-marketdatabecausemarketdataon PyPI is an unrelated, abandoned project (marketData0.2.0, last released 2020-04-19 — PyPI normalises both to the same name).A dependency names the distribution, so this has to follow. Left as
marketdata>=0.1.0it would either fail to resolve against the editable sibling or — worse — succeed by fetching a stranger's 2020 module.The import is untouched. Every call site still says
import marketdata, which is the whole reason the distribution was renamed rather than the package.Verified in a clean venv, and that mattered
My working venv had a stale
marketdatadist-info sitting beside the newcrucible-marketdata, sopip checkpassed on a leftover and proved nothing:From scratch, only
crucible-marketdatainstalls,import marketdataresolves, and 238 tests pass. Ruff clean.Land with mspinola/marketdata#9 and mspinola/cot-analyzer#28 — the three are one change.
Generated by Claude Code