fix(build): demote MLX header folding warning - #23
Merged
mudler merged 2 commits intoAug 2, 2026
Conversation
Apply the AppleClang exception to the MLX provider source after the target-wide Objective-C++ warning policy. This keeps the diagnostic visible while preventing the external header warning from being promoted by -Werror. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5
AppleClang's target-level -Werror still promotes the MLX header warning after the source-level -Wno-error option. Disable only this external-header diagnostic on the MLX provider translation unit. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wgnu-folding-constantwarning only formetal_mlx_provider.mm-Werrorfor every other warningvllm_cpp_set_warnings(vllm)This fixes the repeated Darwin failure observed while integrating the MLX provider in mudler/LocalAI#11137.
target_include_directories(... SYSTEM)is insufficient for this diagnostic, and downstreamCMAKE_OBJCXX_FLAGSworkarounds lose to vllm.cpp's later target-level-Werror.Verification
git diff --check-Wno-error=gnu-folding-constantoption and confirms the warning is not suppressedcmake; Darwin CI is the compiler-level verification