Skip to content

fix(build): demote MLX header folding warning #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 2 commits into from
Aug 2, 2026
Merged

fix(build): demote MLX header folding warning #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f59cf54
fix(build): demote MLX header folding warning
localai-org-maint-bot Aug 2, 2026
865593b
fix(build): suppress MLX folding diagnostic
localai-org-maint-bot Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,6 +831,12 @@ if(VLLM_CPP_METAL)
endif()
target_compile_definitions(vllm PUBLIC VLLM_CPP_MLX)
target_sources(vllm PRIVATE src/vt/metal/metal_mlx_provider.mm)
# MLX 0.29.x headers use GNU-folding expressions that AppleClang diagnoses.
# Suppress that one external-header diagnostic for this TU. A source-level
# -Wno-error is ordered before vllm_cpp_set_warnings' target-level -Werror,
# so AppleClang promotes it again.
set_source_files_properties(src/vt/metal/metal_mlx_provider.mm PROPERTIES
COMPILE_OPTIONS "$<$<COMPILE_LANG_AND_ID:OBJCXX,AppleClang>:-Wno-gnu-folding-constant>")
# SYSTEM so MLX's own headers cannot break our -Werror build.
target_include_directories(vllm SYSTEM PRIVATE "${MLX_ROOT}/include")
target_link_libraries(vllm PUBLIC ${MLX_LIBRARY})
Expand Down
Loading