Hotfix/improve logs - #14
Merged
Merged
Conversation
…a max value at compile time
JosephBowkett
approved these changes
Sep 1, 2026
JosephBowkett
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, definitely want to be mapping print statements to the rclcpp functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump:minor
elevate c prints from jsd to ros2 logs, so
@willreid-jpl @JosephBowkett @preston-rogers @kwehage This recovers fcat-casah capability to show jsd logs as ros logs, but without making them EVRs
Example what it showed before in log file:
It does not show all jsd initialization.
Example what it shows now now in both terminal and log file
See side by side in an online run in astrobud, showing this PR shows jsd logs to both terminal and logs
