fix: add volunteer type filter to volunteer search#523
Merged
Conversation
Closed
2 tasks
Closes #369 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closes #423 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Part of #423 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… develop SDK 0.0.83 added PAST to VolunteerStateMatchType. Both Record<VolunteerStateMatchType> maps were exhaustiveness-checked and missing the new value, causing typecheck to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nadavosa
force-pushed
the
fix/369-volunteer-type-filter
branch
from
83064db to
c8696a9
Compare
These fields are not yet in the published SDK (need4deed-sdk@0.0.85). Restore the cast pattern from before to unblock typecheck. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ivannissimrch
requested changes
May 19, 2026
Collaborator
ivannissimrch
left a comment
ivannissimrch
left a comment
There was a problem hiding this comment.
The volunteer type filter labels and match status labels render as raw translation keys in both EN and DE. The code references dashboard.volunteers.filters.volunteerType_title, dashboard.volunteers.filters.volunteerType_options.*, and dashboard.volunteers.matchStatus.* but none of these paths exist in either locale file.
Adds to dashboard.volunteers.filters: volunteerType_title, volunteerType_options Adds to dashboard.volunteers: matchStatus (vol-* keys) Both EN and DE locales updated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Fixed in e169cb8 — added the missing translation keys to both EN and DE locale files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?type=accompanying&type=regularetc. — the BE already supportsfilter.typeviagetVolunteerWhereRelated
Test plan
/dashboard/volunteers, expand filters panel?type=regularetc.🤖 Generated with Claude Code