Omit fileid for viewer#13134
Merged
Merged
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
ChristophWurst
approved these changes
Jun 22, 2026
| import NoTrashMailboxConfiguredError | ||
| from '../errors/NoTrashMailboxConfiguredError.js' | ||
| import logger from '../logger.js' | ||
| import AttachementMixin from '../mixins/AttachementMixin.js' |
Member
There was a problem hiding this comment.
I thought the other PR fixed that already, nvm
Member
|
Could you find out when fileid was dropped from being a required field for the viewer data model? |
Contributor
Author
I don't know if it ever was required. The interface in the viewer app always had it as optional. |
Contributor
Author
|
/backport c8e3de3 to stable5.9 |
Contributor
Author
|
/backport c8e3de3 to stable5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)