Skip to content

Omit fileid for viewer #13134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 2 commits into from
Jun 22, 2026
+4 −5
Merged

Omit fileid for viewer #13134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e3de3
fix: Omit fileid for attachments
kesselb Jun 21, 2026
3ff9bb5
refactor: Rename AttachementMixin to AttachmentMixin
kesselb Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Envelope.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ import { matchError } from '../errors/match.js'
import NoTrashMailboxConfiguredError
from '../errors/NoTrashMailboxConfiguredError.js'
import logger from '../logger.js'
import AttachementMixin from '../mixins/AttachementMixin.js'

@ChristophWurst ChristophWurst Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 #13128

@kesselb kesselb Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@ChristophWurst ChristophWurst Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the other PR fixed that already, nvm

import AttachmentMixin from '../mixins/AttachmentMixin.js'
import { buildRecipients as buildReplyRecipients } from '../ReplyBuilder.js'
import { FOLLOW_UP_TAG_LABEL } from '../store/constants.js'
import useMainStore from '../store/mainStore.js'
Expand Down Expand Up @@ -630,7 +630,7 @@ export default {
draggableEnvelope: DraggableEnvelopeDirective,
},

mixins: [AttachementMixin],
mixins: [AttachmentMixin],

props: {
withReply: {
Expand Down
4 changes: 2 additions & 2 deletions src/components/MessageAttachments.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ import CloudDownload from 'vue-material-design-icons/CloudDownloadOutline.vue'
import Download from 'vue-material-design-icons/TrayArrowDown.vue'
import MessageAttachment from './MessageAttachment.vue'
import Logger from '../logger.js'
import AttachementMixin from '../mixins/AttachementMixin.js'
import AttachmentMixin from '../mixins/AttachmentMixin.js'
import { saveAttachmentsToFiles } from '../service/AttachmentService.js'

export default {
Expand All @@ -89,7 +89,7 @@ export default {
FilePicker,
},

mixins: [AttachementMixin],
mixins: [AttachmentMixin],
props: {
envelope: {
required: true,
Expand Down
1 change: 0 additions & 1 deletion src/mixins/AttachementMixin.js → src/mixins/AttachmentMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export default {
mime: attachment.mime,
etag: 'fixme',
hasPreview: false,
fileid: parseInt(attachment.id, 10),
}))
},

Expand Down
Loading