fix: Make the IProvideUserSecretBackend usable#60898
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
CarlSchwan
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
come-nc
approved these changes
Jun 1, 2026
CarlSchwan
force-pushed
the
carl/user-interface
branch
2 times, most recently
from
18c1da1 to
1f4f9e5
Compare
CarlSchwan
added
3. to review
When implementing this for user_saml, I noticed that we do need to make the return value nullable as otherwise there are no way for this feature to be optional for the admin. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/user-interface
branch
from
1f4f9e5 to
be8e80a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When reviewing the implementation for user_saml (nextcloud/user_saml#697), I noticed that we do need to make the return value nullable as otherwise there are no way for this feature to be optional for the admin.
This is not really a breaking change as we can make the return type less strict without breaking an implemtable interface and more importantly no one use this interface.
Checklist
3. to review, feature component)stable32)AI (if applicable)