Skip to content

fix: Make the IProvideUserSecretBackend usable #60898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Make the IProvideUserSecretBackend usable #60898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/public/Authentication/IProvideUserSecretBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

namespace OCP\Authentication;

use OCP\HintException;

/**
* Interface IProvideUserSecretBackend
*
Expand All @@ -18,8 +20,14 @@ interface IProvideUserSecretBackend {
/**
* Optionally returns a stable per-user secret. This secret is for
* instance used to secure file encryption keys.
* @return string
*
* @return non-empty-string|null Returns the per-user secret if the backend
* is configured or null otherwise.
* @throws HintException when the backend is configured to return a per-user
* secret but is unable to do so.
*
* @since 23.0.0
* @since 35.0.0 The returns value is now optional.
*/
public function getCurrentUserSecret(): string;
public function getCurrentUserSecret(): ?string;
}
7 changes: 5 additions & 2 deletions lib/public/User/Backend/ICheckPasswordBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,14 @@
*/
interface ICheckPasswordBackend {
/**
* @since 14.0.0
* Check if the password is correct without logging in the user
* returns the user id or false.
*
* @param string $loginName The loginname
* @param string $loginName The login name
* @param string $password The password
* @return string|false The uid on success false on failure
* @since 14.0.0
*
*/
public function checkPassword(string $loginName, string $password);
}
Loading