perf(user_ldap): chunk oracle queries for lower bind cost#60930
Open
miaulalala wants to merge 1 commit into
Open
perf(user_ldap): chunk oracle queries for lower bind cost#60930miaulalala wants to merge 1 commit into
miaulalala wants to merge 1 commit into
Conversation
miaulalala
requested review from
Altahrim,
artonge,
come-nc,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
come-nc
previously approved these changes
Jun 2, 2026
Contributor
Author
|
/backport to stable34 |
miaulalala
added
3. to review
provokateurin
previously approved these changes
Jun 2, 2026
miaulalala
force-pushed
the
test/noid/user-ldap-large-annotation
branch
from
bd71bf9 to
7d43864
Compare
Contributor
|
It does not work, somehow the timeout is still 300 |
miaulalala
force-pushed
the
test/noid/user-ldap-large-annotation
branch
from
7d43864 to
3cdeb01
Compare
miaulalala
changed the title
miaulalala
force-pushed
the
test/noid/user-ldap-large-annotation
branch
from
3cdeb01 to
ad781be
Compare
Oracle's OCI8 driver binds each named parameter individually via OCIBindByName, making queries with 65 000 parameters dramatically slower than on MySQL or PostgreSQL — slow enough to time out in CI and degrade production LDAP syncs on large installations. Lower maxSlices to 5 for Oracle (5 000 params/query) via a match expression alongside the existing SQLite special-case. SQLite and all other databases are unchanged. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
test/noid/user-ldap-large-annotation
branch
from
ad781be to
2faf837
Compare
provokateurin
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oracle's OCI8 driver binds each named parameter individually via
OCIBindByName, making queries with 65 000 parameters dramatically
slower than on MySQL or PostgreSQL — slow enough to time out in CI
and degrade production LDAP syncs on large installations.
Lower maxSlices to 5 for Oracle (5 000 params/query) via a match
expression alongside the existing SQLite special-case. SQLite and
all other databases are unchanged.
🤖 Generated with Claude Code
Assisted-by: ClaudeCode:claude-sonnet-4-6