Skip to content

perf(user_ldap): chunk oracle queries for lower bind cost #60930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miaulalala wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

perf(user_ldap): chunk oracle queries for lower bind cost #60930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/user_ldap/lib/Mapping/AbstractMapping.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,13 @@ protected function collectResultsFromListOfIdsQuery(IQueryBuilder $qb, array &$r
public function getListOfIdsByDn(array $fdns): array {
$totalDBParamLimit = 65000;
$sliceSize = 1000;
$maxSlices = $this->dbc->getDatabaseProvider() === IDBConnection::PLATFORM_SQLITE ? 9 : $totalDBParamLimit / $sliceSize;
// SQLite's variable limit is very low; Oracle's OCI8 driver has high per-bind overhead,
// making large parameter lists (65k) extremely slow — use smaller batches for both.
$maxSlices = match ($this->dbc->getDatabaseProvider()) {
IDBConnection::PLATFORM_SQLITE => 9,
IDBConnection::PLATFORM_ORACLE => 5,
default => $totalDBParamLimit / $sliceSize,
};
$results = [];

$slice = 1;
Expand Down
2 changes: 1 addition & 1 deletion apps/user_ldap/tests/Mapping/AbstractMappingTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ public function testGetListOfIdsByDn(): void {
[$mapper,] = $this->initTest();

$listOfDNs = [];
// List size exceeds the implementation's 65000-parameter chunk limit, forcing multiple chunked queries
// List size exceeds any single-query chunk limit (65k for most DBs, 9k for SQLite, 5k for Oracle), forcing multiple chunked queries
for ($i = 0; $i < 66640; $i++) {
$name = 'as_' . $i;
$dn = 'uid=' . $name . ',dc=example,dc=org';
Expand Down
Loading