Skip to content

fix: disable open link button for unsafe link#8651

Merged
mejo- merged 1 commit into
mainfrom
link-safty-check
Jun 1, 2026
Merged

fix: disable open link button for unsafe link#8651
mejo- merged 1 commit into
mainfrom
link-safty-check

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud commented May 26, 2026

📝 Summary

  • Resolves: Disables the "Open link" button for unsafe links and updates the tooltip and aria-label to provide clear feedback to users.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Link/LinkBubbleView.vue 72.72% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luka-nextcloud. I have one comment.

Comment thread src/components/Link/LinkBubbleView.vue Outdated
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@mejo-
Copy link
Copy Markdown
Member

mejo- commented Jun 1, 2026

/backport to stable34

@mejo-
Copy link
Copy Markdown
Member

mejo- commented Jun 1, 2026

/backport to stable33

@mejo- mejo- merged commit ee2ca26 into main Jun 1, 2026
65 checks passed
@mejo- mejo- deleted the link-safty-check branch June 1, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants