Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/components/Link/LinkBubbleView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
</div>
<!-- open link -->
<NcButton
:title="t('text', 'Open link')"
:aria-label="t('text', 'Open link')"
:disabled="!isSafeHref"
:title="openLinkTitle"
:aria-label="openLinkTitle"
variant="tertiary"
@click="openLink(href)">
<template #icon>
Expand Down Expand Up @@ -98,6 +99,7 @@ import OpenInNewIcon from 'vue-material-design-icons/OpenInNew.vue'
import PencilOutlineIcon from 'vue-material-design-icons/PencilOutline.vue'

import { useOpenLinkHandler } from '../../composables/useOpenLinkHandler.ts'
import { PROTOCOLS_TO_LINK_TO } from '../../marks/Link.ts'
import PreviewOptions from '../Editor/PreviewOptions.vue'

const PROTOCOLS_WITH_PREVIEW = ['http:', 'https:']
Expand Down Expand Up @@ -170,6 +172,27 @@ export default {
return false
}
},

isSafeHref() {
try {
const url = new URL(this.href, window.location)
return !!this.href && PROTOCOLS_TO_LINK_TO.includes(url.protocol)
} catch {
return false
}
},

openLinkTitle() {
if (this.isSafeHref) {
return t('text', 'Open link')
}

if (!this.href) {
return t('text', 'No link available to open')
}

return t('text', 'Cannot open links with unsafe protocols')
},
},

watch: {
Expand Down
2 changes: 1 addition & 1 deletion src/marks/Link.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { defaultMarkdownSerializer } from 'prosemirror-markdown'
import { domHref, parseHref } from '../helpers/links.js'
import { linkClicking } from '../plugins/links'

const PROTOCOLS_TO_LINK_TO = ['http:', 'https:', 'mailto:', 'tel:']
export const PROTOCOLS_TO_LINK_TO = ['http:', 'https:', 'mailto:', 'tel:']

const extractHrefFromMatch = (match: ExtendedRegExpMatchArray) => {
return { href: match.groups?.href }
Expand Down
Loading