Skip to content

test(firmware): verify virtual Linux GPIO through flat hardware modules - #54

Merged
nicksan222 merged 1 commit into
mainfrom
feat/firmware-linux-gpio-e2e
Sep 25, 2026
Merged

nicksan222 merged 1 commit into
mainfrom
feat/firmware-linux-gpio-e2e

Conversation

@nicksan222

Copy link
Copy Markdown
Owner

Summary

  • Flatten firmware hardware modules by role: pins.rs for board descriptors, buttons.rs for events/polling, debounce.rs for timing, and linux_gpio.rs for Linux device access. Keep hardware::pins::* intact.
  • Add a Linux GPIO reader for the board's active-low buttons (internal pull-ups by default), with an external-bias option for simulated inputs.
  • Reuse the existing QEMU E2E guest with gpio-sim: drive one representative button through /dev/gpiochip* and assert typed press/release events reach the real firmware runtime. The existing scripted tests remain responsible for all 12 pin mappings, bounce, held inputs, and read failures.
  • Sync the root and isolated Yocto Cargo locks and crate fetch metadata.

Verification

  • just --justfile apps/firmware/justfile check (including the default Docker/QEMU E2E suite)
  • just --justfile apps/firmware/justfile yocto-check
  • just --justfile apps/firmware/justfile cross-build
  • Guest probe also reached LINUX_VM_PASS under QEMU software emulation without KVM (before the module-only layout refactor).

The test exercises real guest-kernel GPIO, not Pi electrical hardware or a built Yocto image. The Linux reader is not yet attached to the production executable's startup.

@cursor

cursor Bot commented Sep 24, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_86897a04-5cd2-4d8f-9888-0974ec97a9f8)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T16:52:46.853357Z 11953bb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking comment and did not approve. Cursor Bugbot was present but skipped (usage limit / incomplete results), so human review is needed. No reviewers were assigned because the only code owner is the PR author.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@nicksan222
nicksan222 added this pull request to stack #56 September 24, 2026 17:52
@nicksan222
nicksan222 merged commit 1899542 into main Sep 25, 2026
20 checks passed
@nicksan222
nicksan222 deleted the feat/firmware-linux-gpio-e2e branch September 25, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant