Repository navigation
fix: bring 1.44 (long-meeting notes, audio-brief engine, wasapi 0.25) onto main - #4
Merged
Merged
Conversation
Long meetings: over 48,000 characters the notes model read only the start (8 of 35 meetings on the test laptop) and lost every flagged moment, which came after the transcript. Notes for a long meeting are now written from working notes on each part (split at speaker turns, at most 40,000 characters less the flags), combined by the user's own notes prompt. Under 48,000 nothing changes. Flags now come first. Only new notes are read in parts; refine and Audio Brief drafts keep one pass and say when they were cut. Ask says when it read part. Audio brief: PRIV-1 removed the only lookup that found the engine on the test laptop, so it failed with "voice engine not found". Models now has a folder setting (checked first; both engine files required; network paths refused). The Meetings button writes a spoken script first instead of sending raw Markdown notes, and nothing over 330 words is rendered, since the engine stops there silently. Version 1.44.0. Live test on gemma4:12b: a fictional 92,762-character meeting, 3 parts plus combine in 36 s, all three planted code words, all actions with owners and the flag in the notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFrpWY1PdbUjoZTaqkhDRj
wasapi 0.23's WaveFormat::parse is unsound (out-of-bounds read when a copied WAVEFORMATEX header claims an extensible format). Korero never calls parse, and get_mixformat reads from Windows' own pointer, so it was not reachable, but cargo deny now fails on it. 0.25.0 makes parse unsafe. Korero's calls compile unchanged. Side effect: 0.25 shares windows 0.62 with the GUI crates, and test binaries now import TaskDialogIndirect from comctl32.dll directly. That export exists only in Common Controls v6, which comes from the manifest Tauri embeds in the app binary only, so cargo test binaries failed to load (0xC0000139). build.rs now embeds the same manifest (copied from tauri-build 2.5.5) through the linker for every target, and tells Tauri not to add its own. Live test (ignored; Windows with audio playing): loopback captures a quiet 440 Hz tone, 4.02 s at 16 kHz mono, peak 500, rms 353; with nothing playing it fails, as it should. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFrpWY1PdbUjoZTaqkhDRj
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR brings the Kōrero 1.44 fixes onto main, on top of 1.45's speaker separation (#2) and in-room mode (#3). The app version becomes 1.44.0.
The
fix/1.44commits (9a8cfaa,921e897) are cherry-picked here rather than rebased, so the original branch is untouched:notes_parts.rs), and the Notes panel shows progress for each part.tts_engine_dirsetting.Conflicts resolved
src/bindings.tsAppSettings(addstts_engine_dir), plus 1.45'sRoomTranscript,SpeakerSeparationandSpeakerTurntypesuseMeetingsController.tsonBothkeeps 1.44's audio-brief guard (briefStage === "script") and then 1.45's room route (runRoom)meetingJobsStore.tsNotesProgressandphaseLabel, plus 1.45's"speakers"task kindCargo.lockfix/1.44Evidence
cargo test --lib: 283 passed. That is 268 from 1.45 plus 1.44's new tests.bun test unit-tests: 104 passed.--numstatgives the same 22 files with and without--ignore-cr-at-eol. No mojibake.Not yet
fix/1.44can be deleted.🤖 Generated with Claude Code
https://claude.ai/code/session_01M9niYsTjphhTSYCLhCwg5n