Skip to content

Add RVO feature flag to control field import functionality#542

Merged
SvenVw merged 1 commit into
developmentfrom
feature/rvo-feature-flag
Apr 1, 2026
Merged

Add RVO feature flag to control field import functionality#542
SvenVw merged 1 commit into
developmentfrom
feature/rvo-feature-flag

Conversation

@SvenVw
Copy link
Copy Markdown
Collaborator

@SvenVw SvenVw commented Apr 1, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Added feature flag management for RVO field import capabilities. The RVO import functionality across farm dashboards, field creation workflows, and import review pages can now be dynamically toggled between enabled and disabled states. When the feature flag is disabled, users see unavailable status messaging instead of standard import options and workflows.

@SvenVw SvenVw self-assigned this Apr 1, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cc98b1a2-75d7-49ef-a9d8-bc2bf7f7bb37

📥 Commits

Reviewing files that changed from the base of the PR and between 4a112d8 and ca10985.

📒 Files selected for processing (5)
  • .changeset/four-buttons-do.md
  • fdm-app/app/routes/farm.$b_id_farm.$calendar.rvo.tsx
  • fdm-app/app/routes/farm.$b_id_farm._index.tsx
  • fdm-app/app/routes/farm.create.$b_id_farm.$calendar._index.tsx
  • fdm-app/app/routes/farm.create.$b_id_farm.$calendar.rvo.tsx

📝 Walkthrough

Walkthrough

This PR introduces a PostHog feature flag ("rvo") to control access to the RVO (Rijksdienst voor Ondernemers) field import functionality. Four route files now conditionally render RVO-related UI based on the flag status, with disabled states showing a "not available" message instead.

Changes

Cohort / File(s) Summary
Changeset
.changeset/four-buttons-do.md
New changelog entry documenting a patch version bump for @nmi-agro/fdm-app with RVO feature flag addition.
RVO Import Routes with Feature Flag Gating
fdm-app/app/routes/farm.$b_id_farm.$calendar.rvo.tsx, fdm-app/app/routes/farm.create.$b_id_farm.$calendar.rvo.tsx
Added useFeatureFlagEnabled("rvo") check; when disabled, renders early-return "not available" UI with CloudDownload icon instead of normal import flow. Updated lucide-react imports.
Farm Dashboard and Create Pages
fdm-app/app/routes/farm.$b_id_farm._index.tsx, fdm-app/app/routes/farm.create.$b_id_farm.$calendar._index.tsx
Added useFeatureFlagEnabled("rvo") check; conditional rendering of RVO cards now requires both configuration flag and feature flag to be enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

fdm-app, enhancement, branch:development

Suggested reviewers

  • gerardhros
  • BoraIneviNMI

Poem

🐰 A flag now guards the fields so fair,
RVO imports gated with care,
PostHog's check decides the way,
To show or hide them every day! 🌾

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title Check ✅ Passed Title check skipped as CodeRabbit has written the PR title.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/rvo-feature-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot changed the title @coderabbitai Add RVO feature flag to control field import functionality Apr 1, 2026
@SvenVw SvenVw requested a review from BoraIneviNMI April 1, 2026 12:14
@SvenVw SvenVw merged commit 0c363ec into development Apr 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant