Repository navigation
Feedback: Colour contrast used for function parameter type names is too harsh #940
Description
URL:
https://beta.docs.nodejs.org/util.html#utilparseargsconfig
Browser Name:
Chrome
Browser Version:
150.0.7871.125
Operating System:
macOS
How to reproduce the issue:
Hi there, the blog post (https://nodejs.org/en/blog/announcements/new-api-docs-beta) asked for feedback, so I'd just like to mention that I think the background colour used for function parameter type names is too harsh (i.e. the contrast with the white background is too high).
Look at the following example - For the reader, it is visually completely dominated by the type names:
Activity
avivkeller commentedon Jul 25, 2026
I believe these contrasts were intentional cc @nodejs/web-infra
AugustinMauroy commentedon Jul 26, 2026
I didn't recall that. What I recall it's that the classic inline code wasn't clear on the super light green. But we can found an other color that fit better
avivkeller commentedon Jul 27, 2026
I found this reference on us not having a light mode
egorFiNE commentedon Jul 28, 2026
I have been reviewing the new docs and this is the one problem that immediately popped out. I'm using a light scheme and really don't want to look at dark pieces of code. These styles are definitely remnants of a dark theme.
avivkeller commentedon Jul 28, 2026
How does nodejs/nodejs.org#9031 look?
AugustinMauroy commentedon Jul 29, 2026
you pr help but it's not solve the dark inline code in the signature table
frou commentedon Jul 30, 2026
Is it possible to see the original example (https://beta.docs.nodejs.org/util.html#utilparseargsconfig) somewhere with the new changes applied?
avivkeller commentedon Jul 30, 2026
Sure!
frou commentedon Jul 31, 2026
@avivkeller Looks wonderful, thanks!