Standardize checkout-as-app in cd.yaml and release.yaml - #319
Conversation
…composite cd.yaml's bump-and-update-marketplace job and release.yaml's release job each did a separate actions/checkout + local ./.github/actions/github-app-auth composite step. Merge both into the single centralized nsheaps/github-actions/.github/actions/checkout-as-app action (pinned SHA, same one already used in this repo's own test.yaml lint job, and in nsheaps/ai-mktpl), keeping fetch-depth: '0' and the existing id: auth. release.yaml's update-homebrew job is left untouched -- a 'Get job context' step sits between its checkout and auth steps, so merging would require reordering beyond this fix's scope (same precedent followed in nsheaps/dotfiles and nsheaps/claude-utils release.yaml for their analogous update-homebrew jobs). The local ./.github/actions/github-app-auth composite therefore stays in place -- still referenced there. These workflow files are not part of the org's active file-sync (ansible/config/sync-files.yml), so this fix is made directly in this repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0189AKpyNKFsnJbgoMfb31DN
Plugin Version PreviewPreview only — plugin versions and
|
|
CI red on Confirmed pre-existing: Generated by Claude Code Generated by Claude Code |
What changed
.github/workflows/cd.yaml(bump-and-update-marketplacejob): merged the separateactions/checkout@v7(fetch-depth: 0) + local./.github/actions/github-app-authcomposite steps into the single centralizednsheaps/github-actions/.github/actions/checkout-as-appaction (pinned SHA, same one already used in this repo's owntest.yamllint job and innsheaps/ai-mktpl), keepingfetch-depth: '0'and the existingid: auth..github/workflows/release.yaml(releasejob): same conversion.release.yaml'supdate-homebrewjob is left untouched — a "Get job context" step sits between its checkout and auth steps, so merging would require reordering beyond this fix's scope (same precedent followed for the analogousupdate-homebrewjob innsheaps/dotfilesandnsheaps/claude-utils). The local./.github/actions/github-app-authcomposite therefore stays in place, still referenced there.test.yaml'slintjob already correctly used the centralized action — untouched.These workflow files are not part of the org's active file-sync (
ansible/config/sync-files.yml), so this fix is made directly in this repo.Note on scope/timing
This was delayed by a coordination pause with a sibling session ("Review workflow setup across repos") that also has open PRs against this repo (#318, touching
plugins/claude-code/review-utils/*andtemplates/dispatch-review.yaml/deployeddispatch-review.yaml). Verified zero file overlap between that PR and this one before proceeding.Generated by Claude Code