test(objectql): de-flake hook-binder fire-and-forget assertion (#2744) - #2749
Merged
Conversation
…tion instead of wall clock (#2744) The test asserted the wrapped after-event call returned in <20ms; shared CI runners exceed that (observed 23ms on PR #2742), failing an unrelated PR. Replace with an ordering assertion: right after the wrapper resolves, the handler's side effect must not have happened yet — the handler's 30ms timer is a macrotask and cannot fire between the wrapper's resolution and the synchronous check, so this is deterministic regardless of runner speed, while still failing if the wrapper ever starts awaiting the handler (calls would already hold 'done'). Closes #2744. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 13 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2744。
hook-binder.test.ts的 fire-and-forget 用例用墙钟阈值(<20ms)证明"未 await handler",共享 CI runner 慢一点就随机红(PR #2742 实测 23ms,重跑即绿)。改为顺序性断言:wrapper resolve 后同步检查calls仍为空——handler 的 30ms timer 是宏任务,不可能在 wrapper 的 promise 链与同步断言之间触发,与机器快慢无关;而 wrapper 若真 await 了 handler,calls此处必然已是['done'],照样红。测试后半段(60ms 后['done'])不变。纯测试改动;
vitest run src/hook-binder.test.ts15/15 ✓。🤖 Generated with Claude Code