Skip to content

test(objectql): de-flake hook-binder fire-and-forget assertion (#2744) #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 10, 2026
+6 −2
Merged

test(objectql): de-flake hook-binder fire-and-forget assertion (#2744) #2749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/objectql/src/hook-binder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,13 @@ describe('wrapDeclarativeHook', () => {
},
};
const wrapped = wrapDeclarativeHook(meta, meta.handler as any);
const t0 = Date.now();
await wrapped(makeCtx({ event: 'afterInsert' }));
expect(Date.now() - t0).toBeLessThan(20); // returned before handler finished
// Ordering, not wall clock (#2744): if the wrapper had awaited the
// handler, `calls` would already hold 'done' here — the 30ms timer is a
// macrotask and cannot fire between the wrapper's resolution and this
// synchronous check, no matter how slow the runner is. The old
// `< 20ms` wall-clock assertion was flaky on shared CI machines.
expect(calls).toEqual([]); // returned before handler finished
await new Promise((r) => setTimeout(r, 60));
expect(calls).toEqual(['done']);
});
Expand Down