Repository navigation
Support the Egeria 6.3 information supply chain mermaid graphs - #503
Merged
Merged
Conversation
Egeria 6.3 returns up to five mermaid graphs on an
InformationSupplyChainElement retrieved with addImplementation=true,
each present only if it has content.
- Add iscDataMeshMermaidGraph, iscSystemFabricMermaidGraph,
iscDataFabricMermaidGraph and iscDataMappingMermaidGraph to
MERMAID_GRAPHS / MERMAID_GRAPH_TITLES (kept aligned) and to
MERMAID_ATTRIBUTE_KEYS.
- Replace "iscimplementationGraph" in MERMAID_ATTRIBUTE_KEYS, which
matched no field the server sends, with iscImplementationMermaidGraph,
so the ISC implementation graph is fenced instead of printed raw.
- Look mermaid graph keys up case-insensitively: servers before 6.3
wrote iscimplementationMermaidGraph.
- Common-Mermaid and Common-Mermaid-Prop-Value: add a column per new
graph; fix the Prop-Value key (iscImplementationGraph ->
iscImplementationMermaidGraph).
- HTML report page: load mermaid@11 instead of mermaid@10, which cannot
parse Egeria's @{ shape: ... } node syntax.
- Docs table and the solution-architect functional test use the 6.3 key.
From Mandy Chessell's note on the 6.3 ISC graphs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
… specs Generated report specs take their columns from the Create command's attributes, which are inputs. The ISC graphs are server-returned values, so adding them as compact-spec attributes would turn them into authorable template fields. Instead, gen_report_specs gets a GENERATED_EXTRA_COLUMNS table of display-only columns, appended to the ALL format and offered as a MERMAID format. refresh_specs keeps them on every regeneration. Information Supply Chain gets the five Egeria 6.3 ISC graphs. Regenerated with refresh_specs --merge-reports; only Information-Supply-Chain-DrE-Basic and -Advanced change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This was referenced Oct 28, 2026
dwolfson
added a commit
to dwolfson/egeria-python
that referenced
this pull request
Oct 28, 2026
REPORT section headings for the ISC graphs (odpi#503) read "Isc Data Mesh Graph": camel_to_title_case only keeps words listed in REPORT_ACRONYMS upper-case. Add "ISC". This also lets _is_mermaid_attribute's name-based fallback match the "ISC ..." entries in MERMAID_GRAPH_TITLES. Replaces the backlog entry added in the previous commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
added a commit
that referenced
this pull request
Oct 28, 2026
…MNS; backlog item (#505) * docs: GENERATED_EXTRA_COLUMNS, generated spec naming, backlog item - dr_egeria_manual, CLAUDE.md, AGENTS.md: generated report spec columns come from the Create command's attributes; display-only server-returned columns (the ISC mermaid graphs, #503) go in GENERATED_EXTRA_COLUMNS in gen_report_specs.py, not the compact spec. The manual also notes the -DrE-Basic/-DrE-Advanced suffix is required. - BACKLOG: a bare "...-DrE" report spec name silently falls back to the default report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> * docs(backlog): ISC graph headings render as "Isc ..." in REPORT output camel_to_title_case only keeps words listed in REPORT_ACRONYMS upper-case, and "ISC" isn't one of them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> * fix(view): keep "ISC" upper-case in report headings REPORT section headings for the ISC graphs (#503) read "Isc Data Mesh Graph": camel_to_title_case only keeps words listed in REPORT_ACRONYMS upper-case. Add "ISC". This also lets _is_mermaid_attribute's name-based fallback match the "ISC ..." entries in MERMAID_GRAPH_TITLES. Replaces the backlog entry added in the previous commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> --------- Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Egeria 6.3 returns up to five mermaid graphs on an
InformationSupplyChainElementretrieved withaddImplementation=true, each present only if it has content (from Mandy Chessell's note on the 6.3 ISC graphs). This PR makes pyegeria render all five.iscImplementationMermaidGraphiscDataMeshMermaidGraphiscSystemFabricMermaidGraphiscDataFabricMermaidGraphiscDataMappingMermaidGraphChanges
MERMAID_GRAPHS/MERMAID_GRAPH_TITLES(kept aligned) and toMERMAID_ATTRIBUTE_KEYS.MERMAID_ATTRIBUTE_KEYSheld"iscimplementationGraph", which matches no field the server has ever sent, so the ISC implementation graph printed as raw text in reports. It now usesiscImplementationMermaidGraph.iscimplementationMermaidGraph(Jackson lower-cased the leading "ISC"). Graph keys are now matched case-insensitively, exact match first, in both the report-column and MERMAID output paths.Common-Mermaid/Common-Mermaid-Prop-Value: a column for each new graph. The Prop-Value keyiscImplementationGraphis fixed.Information-Supply-Chain-DrE-Basic/Advanced: these generated specs now show the five graphs in the ALL format and offer a MERMAID format. The columns come from a newGENERATED_EXTRA_COLUMNStable ingen_report_specs.py, not from the compact spec. The graphs are server-returned values, so adding them as compact-spec attributes would turn them into authorable template fields. Regenerated withrefresh_specs --merge-reports; only these two specs change.@{ shape: … }node syntax, so no Egeria graph drew there. This predates 6.3.Testing
find_information_supply_chains("SAMPLE Information Supply Chain", add_implementation=True)underlineage_visible()returnedSAMPLE-InformationSupplyChain:Deployment-Status-Demonstrationwith all fiveisc*MermaidGraphkeys. REPORT output withInformation-Supply-Chain-DrE-Basicrendered 5 mermaid fences, andCommon-Mermaidrendered 6 (plusmermaidGraph), with no graph text left outside a fence. The MERMAID format rendered all 5.🤖 Generated with Claude Code
https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g