Skip to content

test(e2e): screenshot the capture opt-in control (Task 1 evidence) - #63

Merged
alichherawalla merged 1 commit into
mainfrom
test/capture-optin-e2e
Jul 24, 2026
Merged

test(e2e): screenshot the capture opt-in control (Task 1 evidence)#63
alichherawalla merged 1 commit into
mainfrom
test/capture-optin-e2e

Conversation

@alichherawalla

Copy link
Copy Markdown
Contributor

Paired e2e evidence for desktop-pro #34 (capture explicit opt-in per device). E2E specs live in core, so the screenshot lands here.

What

Adds a capture Settings — capture opt-in control case to the existing screenshots-quality-hardening spec: navigates to Settings, expands the Capture & processing section, and screenshots the opt-in surface (status label + Pause/Restart controls + screen-access state).

Screenshot

e2e/screenshots/qh-settings-capture-optin.png — verified by reading the image: on macOS it shows Capturing (green) · SCREEN ACCESS: granted · an explicit Pause capture control. That is the darwin branch of the fix (capture active, permission-gated). The win32/linux paused default is a main-process rule not observable on a macOS e2e host — proven by the real-seam integration test in desktop-pro #34.

Tests

  • npx playwright test -g "capture opt-in control" → 1 passed. Screenshot read + validated per the mandatory screenshot-validation rule.
  • prettier clean; pushed through the tsc + coverage pre-push gate.

…evidence)

Expands the 'Capture & processing' section and captures the opt-in surface —
status label + Pause/Restart controls + screen-access state. On macOS this shows
the darwin branch (capture active, permission-gated); the win32/linux paused
default is a main-process rule proven by the real-seam integration test in
desktop-pro (captureStartsPaused + configureCaptureSettings over a real SettingsStore).
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@alichherawalla, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cf0ca978-51a0-40ad-a8cf-103655294144

📥 Commits

Reviewing files that changed from the base of the PR and between 100d6a3 and 23193c4.

⛔ Files ignored due to path filters (1)
  • e2e/screenshots/qh-settings-capture-optin.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • e2e/screenshots-quality-hardening.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/capture-optin-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@alichherawalla
alichherawalla merged commit 1c0d6f9 into main Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant