Skip to content

docs(rules): native builds now run on pre-push, not CI - #609

Merged
alichherawalla merged 1 commit into
mainfrom
docs/rules-prepush-native-builds
Jul 24, 2026
Merged

docs(rules): native builds now run on pre-push, not CI#609
alichherawalla merged 1 commit into
mainfrom
docs/rules-prepush-native-builds

Conversation

@alichherawalla

@alichherawalla alichherawalla commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #608. Updates rules.md's pre-push gate table to document the Android (assembleDebug assembleRelease) and iOS (simulator, no-signing) builds that now run locally on push, and notes the CI android-build was removed. Docs-only.

Summary by CodeRabbit

  • Documentation
    • Updated pre-push quality gate guidance to include Android and iOS native build checks.
    • Clarified local execution requirements, including SwiftLint installation and an available iOS simulator SDK.
    • Documented that native builds run locally rather than in CI.

Update the pre-push gate table: Android (assembleDebug assembleRelease) and iOS (simulator,
no-signing) builds now run locally on push, scoped to native/gradle/pods/deps changes. Note the
CI android-build was removed (hung 3+ hours). Verified: assembleRelease builds both APKs locally.
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@alichherawalla
alichherawalla merged commit f845398 into main Jul 24, 2026
2 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a51e214-8a57-4b41-b1ea-8601b5facae1

📥 Commits

Reviewing files that changed from the base of the PR and between d033959 and ccbb3f3.

📒 Files selected for processing (1)
  • rules.md

📝 Walkthrough

Walkthrough

The PRE-PUSH quality-gates documentation now includes local Android Gradle debug/release builds and unsigned iOS simulator builds, clarifies that native builds do not run in hosted CI, and expands SwiftLint and simulator setup requirements.

Changes

Native pre-push gates

Layer / File(s) Summary
Document native build requirements
rules.md
The PRE-PUSH checks table adds Android assembleDebug/assembleRelease and an iOS simulator build with CODE_SIGNING_ALLOWED=NO, while the requirements text covers local execution, SwiftLint, and simulator availability.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • off-grid-ai/OGAM#608: Documents the corresponding move of native builds from CI into the PRE-PUSH hook.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/rules-prepush-native-builds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant