Skip to content

docs(rules): native builds now run on pre-push, not CI #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alichherawalla merged 1 commit into from
Jul 24, 2026
Merged

docs(rules): native builds now run on pre-push, not CI #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,20 @@ since upstream:

| Pushed file type | Checks that run automatically (pre-push) |
|---|---|
| `.ts` / `.tsx` / `.js` / `.jsx` | eslint, `tsc --noEmit`, `jest --findRelatedTests`, `npm run depcruise` |
| `.swift` | `npm run test:ios` |
| `.kt` / `.kts` | `npm run test:android` |
| `.ts` / `.tsx` / `.js` / `.jsx` | eslint, `tsc --noEmit`, `jest --findRelatedTests`, `npm run depcruise`, `npm run knip` |
| `.swift` | SwiftLint, `npm run test:ios` |
| `.kt` / `.kts` | `compileDebugKotlin`, `lintDebug`, `npm run test:android` |
| `.kt` / `.kts` · `android/` · `package*.json` | **Android build** `./gradlew assembleDebug assembleRelease` |
| `.swift` · `ios/` · `Podfile` | **iOS build** (simulator, `CODE_SIGNING_ALLOWED=NO`) |

**The native builds are a LOCAL pre-push gate, NOT in CI.** The hosted `android-build` CI job hung for
3+ hours on the native C++ builds and was removed; both builds now run on push (scoped above so JS-only
/ docs pushes stay fast). CI keeps lint / typecheck / test / architecture / SonarCloud / CodeRabbit.

**Requirements:**
- SwiftLint: `brew install swiftlint` (skipped with a warning if not installed)
- Android checks require the Gradle wrapper in `android/`
- Android checks require the Gradle wrapper in `android/`; the iOS build needs a booted-or-available
simulator SDK. Verified locally: `assembleDebug assembleRelease` produces both APKs (~14 min).

**Workflow implication (TDD / adversarial red-first):** write a failing test, commit it red (commit is
free), then drive it green; the branch must be green before `git push` (the gate blocks a red push).
Expand Down
Loading