Skip to content

Hand a thumbnailer a name that holds a code as it is - #175

Open
dhh wants to merge 2 commits into
mainfrom
thumbnailer-percent-names
Open

dhh wants to merge 2 commits into
mainfrom
thumbnailer-percent-names

Conversation

@dhh

@dhh dhh commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Based on #67 by @thisisgm.

A thumbnailer's command was filled in one code after another, so a file called 50%off.mp4 had the %o in its own name replaced by the output path. The thumbnailer was sent a file that is not there, and the failure was remembered. Each code is now read once.

Files that failed only because of what this fixes kept their failure markers, which hold a file back before the fix is reached, so the markers' round goes to 3 and each is tried once more. The same change is in the other thumbnail fixes (#175, #176, #186), so they merge in any order.

🤖 Generated with Claude Code

A thumbnailer's command was filled in one code after another, so a
file called 50%off.mp4 had the %o in its own name replaced by the
output path. The thumbnailer was sent a file that is not there, and
the failure was remembered. Each code is now read once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the previous blocking issue is fixed and no new issues were found.

Summary

The PR preserves filenames containing thumbnail command codes and retries files blocked by old saved failures.

  • Thumbnailers receive file names with percent codes intact.
  • Files marked as failed in round 2 get another thumbnail attempt.

The previous cache finding is fixed. No new issues found.

Reviews (2) · Last reviewed commit: "Try again what failed before these thumb..." · Reviewed by Greptile

Comment thread src/thumbnails.cpp Resolved
Files that failed only because of what's fixed here (a name holding a
%, a helper that never started, a camera RAW Folio couldn't read) kept
their failure markers, and those hold a file back before any of the
fixes are reached, so they stayed blank until the file changed. The
markers' round goes to 3, so each is tried once more. The same change
is in each of the thumbnail fixes, so they merge in any order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants