Repository navigation
Conversation
[Medium impact] This PR appears safe to merge; no new blocking issues were found. SummaryThis PR stops temporary thumbnail failures from being remembered as file failures.
No new actionable issues found. Tests were inspected but not run. Reviews (3) · Last reviewed commit: "Try again what failed before these thumb..." · Reviewed by Greptile |
This was referenced Nov 18, 2026
A failure marker keeps every app from trying a file again, and one was written for a thumbnailer that never started, for a .thumbnailer file whose program is not installed, for a file that could not be read and for one moved away or written to during the run. None of those says the file is broken, so none is remembered now, and a PDF whose thumbnailer cannot start is left to pdftoppm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Files that failed only because of what's fixed here (a name holding a %, a helper that never started, a camera RAW Folio couldn't read) kept their failure markers, and those hold a file back before any of the fixes are reached, so they stayed blank until the file changed. The markers' round goes to 3, so each is tried once more. The same change is in each of the thumbnail fixes, so they merge in any order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhh
force-pushed
the
thumbnail-failures-judged
branch
from
November 18, 2026 16:23
2c0a169 to
66a3ad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #67 by @thisisgm.
A failure marker keeps every app from trying a file again, and one was written for a thumbnailer that never started, for a .thumbnailer file whose program is not installed, for a file that could not be read and for one moved away or written to during the run. None of those says the file is broken, so none is remembered now, and a PDF whose thumbnailer cannot start is left to pdftoppm.
Files that failed only because of what this fixes kept their failure markers, which hold a file back before the fix is reached, so the markers' round goes to 3 and each is tried once more. The same change is in the other thumbnail fixes (#175, #176, #186), so they merge in any order.
🤖 Generated with Claude Code