Skip to content

Remember a failed thumbnail only when its file was judged - #176

Open
dhh wants to merge 2 commits into
mainfrom
thumbnail-failures-judged
Open

dhh wants to merge 2 commits into
mainfrom
thumbnail-failures-judged

Conversation

@dhh

@dhh dhh commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Based on #67 by @thisisgm.

A failure marker keeps every app from trying a file again, and one was written for a thumbnailer that never started, for a .thumbnailer file whose program is not installed, for a file that could not be read and for one moved away or written to during the run. None of those says the file is broken, so none is remembered now, and a PDF whose thumbnailer cannot start is left to pdftoppm.

Files that failed only because of what this fixes kept their failure markers, which hold a file back before the fix is reached, so the markers' round goes to 3 and each is tried once more. The same change is in the other thumbnail fixes (#175, #176, #186), so they merge in any order.

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no new blocking issues were found.

Summary

This PR stops temporary thumbnail failures from being remembered as file failures.

  • Folio marks a thumbnail failed only after a readable file gets a real attempt.

No new actionable issues found. Tests were inspected but not run.

Reviews (3) · Last reviewed commit: "Try again what failed before these thumb..." · Reviewed by Greptile

Comment thread src/thumbnails.cpp Resolved
thisisgm and others added 2 commits November 18, 2026 17:20
A failure marker keeps every app from trying a file again, and one was
written for a thumbnailer that never started, for a .thumbnailer file
whose program is not installed, for a file that could not be read and
for one moved away or written to during the run. None of those says the
file is broken, so none is remembered now, and a PDF whose thumbnailer
cannot start is left to pdftoppm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Files that failed only because of what's fixed here (a name holding a
%, a helper that never started, a camera RAW Folio couldn't read) kept
their failure markers, and those hold a file back before any of the
fixes are reached, so they stayed blank until the file changed. The
markers' round goes to 3, so each is tried once more. The same change
is in each of the thumbnail fixes, so they merge in any order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dhh
dhh force-pushed the thumbnail-failures-judged branch from 2c0a169 to 66a3ad4 Compare November 18, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants