Repository navigation
Sign in with a domain, as a guest or with the keyring - #189
Open
dalmasluca wants to merge 3 commits into
Open
dalmasluca wants to merge 3 commits into
dalmasluca wants to merge 3 commits into
Conversation
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe sign-in dialog adds domain entry, guest access, and an optional keyring choice based on what GVfs supports.
No new actionable issues found. Reviews (2) · Last reviewed commit: "Send a cleared domain empty on the next ..." · Reviewed by Greptile |
When GVfs asks for a password, the sign-in dialog now offers what GVfs says the server allows: a domain or workgroup field when one is needed, Connect as Guest when anonymous access is supported, and a checkbox to keep the password in the keyring when saving it is. Without the checkbox the password is still kept for the session only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since omacom#187 every piece of text in Folio is a FolioText, so it follows the system's font and text size live. The sign-in dialog's new "Remember the password in the keyring" label was a plain Text, drawn in Qt's default font instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GVfs asks for a password again on the same mount operation after a failed login. The domain was only set when the field had something in it, so clearing it for the next attempt left the operation holding the previous domain, and GVfs got that again instead of the empty one given. When the server asks for a domain, it's now set as given, empty or not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GVfs asks for a password, the sign-in dialog now offers what GVfs says the server allows:
Split from #35.
Before:
After, for a Windows share that needs a domain and where the keyring can save the password (the server and share names are hidden):
🤖 Generated with Claude Code