Skip to content

Sign in with a domain, as a guest or with the keyring - #189

Open
dalmasluca wants to merge 3 commits into
omacom:mainfrom
dalmasluca:sign-in-options
Open

dalmasluca wants to merge 3 commits into
omacom:mainfrom
dalmasluca:sign-in-options

Conversation

@dalmasluca

@dalmasluca dalmasluca commented Nov 18, 2026 •

Copy link
Copy Markdown

When GVfs asks for a password, the sign-in dialog now offers what GVfs says the server allows:

  • A Domain or workgroup field, when the server needs one.
  • Connect as Guest, when it takes anonymous access.
  • Remember the password in the keyring, when saving is supported. The choice is kept for next time; unticked, the password is kept for the session only, as before.

Split from #35.

Before:

The sign-in dialog before: user and password

After, for a Windows share that needs a domain and where the keyring can save the password (the server and share names are hidden):

The sign-in dialog after: user, domain, password and the keyring checkbox

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

The sign-in dialog adds domain entry, guest access, and an optional keyring choice based on what GVfs supports.

  • Sign-in prompts can include a domain and save passwords in the keyring.
  • Eligible servers can be mounted with a guest sign-in.

No new actionable issues found.

Reviews (2) · Last reviewed commit: "Send a cleared domain empty on the next ..." · Reviewed by Greptile

Comment thread src/mounter.cpp Resolved
dalmasluca and others added 3 commits November 18, 2026 17:29
When GVfs asks for a password, the sign-in dialog now offers what GVfs
says the server allows: a domain or workgroup field when one is needed,
Connect as Guest when anonymous access is supported, and a checkbox to
keep the password in the keyring when saving it is. Without the
checkbox the password is still kept for the session only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since omacom#187 every piece of text in Folio is a FolioText, so it follows
the system's font and text size live. The sign-in dialog's new
"Remember the password in the keyring" label was a plain Text, drawn in
Qt's default font instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GVfs asks for a password again on the same mount operation after a
failed login. The domain was only set when the field had something in
it, so clearing it for the next attempt left the operation holding the
previous domain, and GVfs got that again instead of the empty one
given. When the server asks for a domain, it's now set as given, empty
or not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants